diff options
author | Tejun Heo <htejun@gmail.com> | 2008-04-07 09:47:16 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:21 -0400 |
commit | 9363c3825ea9ad76561eb48a395349dd29211ed6 (patch) | |
tree | abe89a0f7c82b805d84b1a211c97b317f6628d5f /drivers/ata/pata_mpiix.c | |
parent | b67a1064cb1c1d3b43e01e8b43a6a8dcdefed733 (diff) |
libata: rename SFF functions
SFF functions have confusing names. Some have sff prefix, some have
bmdma, some std, some pci and some none. Unify the naming by...
* SFF functions which are common to both BMDMA and non-BMDMA are
prefixed with ata_sff_.
* SFF functions which are specific to BMDMA are prefixed with
ata_bmdma_.
* SFF functions which are specific to PCI but apply to both BMDMA and
non-BMDMA are prefixed with ata_pci_sff_.
* SFF functions which are specific to PCI and BMDMA are prefixed with
ata_pci_bmdma_.
* Drop generic prefixes from LLD specific routines. For example,
bfin_std_dev_select -> bfin_dev_select.
The following renames are noteworthy.
ata_qc_issue_prot() -> ata_sff_qc_issue()
ata_pci_default_filter() -> ata_bmdma_mode_filter()
ata_dev_try_classify() -> ata_sff_dev_classify()
This rename is in preparation of separating SFF support out of libata
core layer. This patch strictly renames functions and doesn't
introduce any behavior difference.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_mpiix.c')
-rw-r--r-- | drivers/ata/pata_mpiix.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/ata/pata_mpiix.c b/drivers/ata/pata_mpiix.c index 1b9d0d412ebf..7d7e3fdab71f 100644 --- a/drivers/ata/pata_mpiix.c +++ b/drivers/ata/pata_mpiix.c | |||
@@ -55,7 +55,7 @@ static int mpiix_pre_reset(struct ata_link *link, unsigned long deadline) | |||
55 | if (!pci_test_config_bits(pdev, &mpiix_enable_bits)) | 55 | if (!pci_test_config_bits(pdev, &mpiix_enable_bits)) |
56 | return -ENOENT; | 56 | return -ENOENT; |
57 | 57 | ||
58 | return ata_std_prereset(link, deadline); | 58 | return ata_sff_prereset(link, deadline); |
59 | } | 59 | } |
60 | 60 | ||
61 | /** | 61 | /** |
@@ -69,8 +69,8 @@ static int mpiix_pre_reset(struct ata_link *link, unsigned long deadline) | |||
69 | * | 69 | * |
70 | * This would get very ugly because we can only program timing for one | 70 | * This would get very ugly because we can only program timing for one |
71 | * device at a time, the other gets PIO0. Fortunately libata calls | 71 | * device at a time, the other gets PIO0. Fortunately libata calls |
72 | * our qc_issue_prot command before a command is issued so we can | 72 | * our qc_issue command before a command is issued so we can flip the |
73 | * flip the timings back and forth to reduce the pain. | 73 | * timings back and forth to reduce the pain. |
74 | */ | 74 | */ |
75 | 75 | ||
76 | static void mpiix_set_piomode(struct ata_port *ap, struct ata_device *adev) | 76 | static void mpiix_set_piomode(struct ata_port *ap, struct ata_device *adev) |
@@ -110,7 +110,7 @@ static void mpiix_set_piomode(struct ata_port *ap, struct ata_device *adev) | |||
110 | } | 110 | } |
111 | 111 | ||
112 | /** | 112 | /** |
113 | * mpiix_qc_issue_prot - command issue | 113 | * mpiix_qc_issue - command issue |
114 | * @qc: command pending | 114 | * @qc: command pending |
115 | * | 115 | * |
116 | * Called when the libata layer is about to issue a command. We wrap | 116 | * Called when the libata layer is about to issue a command. We wrap |
@@ -120,7 +120,7 @@ static void mpiix_set_piomode(struct ata_port *ap, struct ata_device *adev) | |||
120 | * be made PIO0. | 120 | * be made PIO0. |
121 | */ | 121 | */ |
122 | 122 | ||
123 | static unsigned int mpiix_qc_issue_prot(struct ata_queued_cmd *qc) | 123 | static unsigned int mpiix_qc_issue(struct ata_queued_cmd *qc) |
124 | { | 124 | { |
125 | struct ata_port *ap = qc->ap; | 125 | struct ata_port *ap = qc->ap; |
126 | struct ata_device *adev = qc->dev; | 126 | struct ata_device *adev = qc->dev; |
@@ -133,7 +133,7 @@ static unsigned int mpiix_qc_issue_prot(struct ata_queued_cmd *qc) | |||
133 | if (adev->pio_mode && adev != ap->private_data) | 133 | if (adev->pio_mode && adev != ap->private_data) |
134 | mpiix_set_piomode(ap, adev); | 134 | mpiix_set_piomode(ap, adev); |
135 | 135 | ||
136 | return ata_qc_issue_prot(qc); | 136 | return ata_sff_qc_issue(qc); |
137 | } | 137 | } |
138 | 138 | ||
139 | static struct scsi_host_template mpiix_sht = { | 139 | static struct scsi_host_template mpiix_sht = { |
@@ -142,7 +142,7 @@ static struct scsi_host_template mpiix_sht = { | |||
142 | 142 | ||
143 | static struct ata_port_operations mpiix_port_ops = { | 143 | static struct ata_port_operations mpiix_port_ops = { |
144 | .inherits = &ata_sff_port_ops, | 144 | .inherits = &ata_sff_port_ops, |
145 | .qc_issue = mpiix_qc_issue_prot, | 145 | .qc_issue = mpiix_qc_issue, |
146 | .cable_detect = ata_cable_40wire, | 146 | .cable_detect = ata_cable_40wire, |
147 | .set_piomode = mpiix_set_piomode, | 147 | .set_piomode = mpiix_set_piomode, |
148 | .prereset = mpiix_pre_reset, | 148 | .prereset = mpiix_pre_reset, |
@@ -207,10 +207,10 @@ static int mpiix_init_one(struct pci_dev *dev, const struct pci_device_id *id) | |||
207 | ap->ioaddr.altstatus_addr = ctl_addr; | 207 | ap->ioaddr.altstatus_addr = ctl_addr; |
208 | 208 | ||
209 | /* Let libata fill in the port details */ | 209 | /* Let libata fill in the port details */ |
210 | ata_std_ports(&ap->ioaddr); | 210 | ata_sff_std_ports(&ap->ioaddr); |
211 | 211 | ||
212 | /* activate host */ | 212 | /* activate host */ |
213 | return ata_host_activate(host, irq, ata_interrupt, IRQF_SHARED, | 213 | return ata_host_activate(host, irq, ata_sff_interrupt, IRQF_SHARED, |
214 | &mpiix_sht); | 214 | &mpiix_sht); |
215 | } | 215 | } |
216 | 216 | ||