diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:51:59 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (patch) | |
tree | 620648585f89cdb589d1625431f8c21ef70a9258 /drivers/ata/pata_macio.c | |
parent | a44fec1fce5d5d14cc3ac4545b8da346394de666 (diff) |
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_macio.c')
-rw-r--r-- | drivers/ata/pata_macio.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index d39c10b61f2b..b057e3fa44bc 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c | |||
@@ -813,7 +813,7 @@ static int pata_macio_slave_config(struct scsi_device *sdev) | |||
813 | blk_queue_update_dma_pad(sdev->request_queue, 31); | 813 | blk_queue_update_dma_pad(sdev->request_queue, 31); |
814 | 814 | ||
815 | /* Tell the world about it */ | 815 | /* Tell the world about it */ |
816 | ata_dev_printk(dev, KERN_INFO, "OHare alignment limits applied\n"); | 816 | ata_dev_info(dev, "OHare alignment limits applied\n"); |
817 | return 0; | 817 | return 0; |
818 | } | 818 | } |
819 | 819 | ||
@@ -839,8 +839,7 @@ static int pata_macio_slave_config(struct scsi_device *sdev) | |||
839 | cmd | PCI_COMMAND_INVALIDATE); | 839 | cmd | PCI_COMMAND_INVALIDATE); |
840 | 840 | ||
841 | /* Tell the world about it */ | 841 | /* Tell the world about it */ |
842 | ata_dev_printk(dev, KERN_INFO, | 842 | ata_dev_info(dev, "K2/Shasta alignment limits applied\n"); |
843 | "K2/Shasta alignment limits applied\n"); | ||
844 | } | 843 | } |
845 | 844 | ||
846 | return 0; | 845 | return 0; |