diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-08-15 05:38:46 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-12 14:55:34 -0400 |
commit | 6d32d30f55020d766388df7515f771f68c973033 (patch) | |
tree | ec0efe48460b5b3f177fed2698ccd04b7964359b /drivers/ata/pata_legacy.c | |
parent | cb94c1cf5a6beffbd8935eb91227df0dd1987644 (diff) |
[libata] Remove ->irq_ack() hook, and ata_dummy_irq_on()
* ->irq_ack() is redundant to what the irq handler already
performs... chk-status + irq-clear. Furthermore, it is only
called in one place, when screaming-irq-debugging is enabled,
so we don't want to bother with a hook just for that.
* ata_dummy_irq_on() is only ever used in drivers that have
no callpath reaching ->irq_on(). Remove .irq_on hook from
those drivers, and the now-unused ata_dummy_irq_on()
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/pata_legacy.c')
-rw-r--r-- | drivers/ata/pata_legacy.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c index cfb2bc86a1d1..6529d34f0370 100644 --- a/drivers/ata/pata_legacy.c +++ b/drivers/ata/pata_legacy.c | |||
@@ -171,7 +171,6 @@ static struct ata_port_operations simple_port_ops = { | |||
171 | .irq_handler = ata_interrupt, | 171 | .irq_handler = ata_interrupt, |
172 | .irq_clear = ata_bmdma_irq_clear, | 172 | .irq_clear = ata_bmdma_irq_clear, |
173 | .irq_on = ata_irq_on, | 173 | .irq_on = ata_irq_on, |
174 | .irq_ack = ata_irq_ack, | ||
175 | 174 | ||
176 | .port_start = ata_port_start, | 175 | .port_start = ata_port_start, |
177 | }; | 176 | }; |
@@ -200,7 +199,6 @@ static struct ata_port_operations legacy_port_ops = { | |||
200 | .irq_handler = ata_interrupt, | 199 | .irq_handler = ata_interrupt, |
201 | .irq_clear = ata_bmdma_irq_clear, | 200 | .irq_clear = ata_bmdma_irq_clear, |
202 | .irq_on = ata_irq_on, | 201 | .irq_on = ata_irq_on, |
203 | .irq_ack = ata_irq_ack, | ||
204 | 202 | ||
205 | .port_start = ata_port_start, | 203 | .port_start = ata_port_start, |
206 | }; | 204 | }; |
@@ -316,7 +314,6 @@ static struct ata_port_operations pdc20230_port_ops = { | |||
316 | .irq_handler = ata_interrupt, | 314 | .irq_handler = ata_interrupt, |
317 | .irq_clear = ata_bmdma_irq_clear, | 315 | .irq_clear = ata_bmdma_irq_clear, |
318 | .irq_on = ata_irq_on, | 316 | .irq_on = ata_irq_on, |
319 | .irq_ack = ata_irq_ack, | ||
320 | 317 | ||
321 | .port_start = ata_port_start, | 318 | .port_start = ata_port_start, |
322 | }; | 319 | }; |
@@ -372,7 +369,6 @@ static struct ata_port_operations ht6560a_port_ops = { | |||
372 | .irq_handler = ata_interrupt, | 369 | .irq_handler = ata_interrupt, |
373 | .irq_clear = ata_bmdma_irq_clear, | 370 | .irq_clear = ata_bmdma_irq_clear, |
374 | .irq_on = ata_irq_on, | 371 | .irq_on = ata_irq_on, |
375 | .irq_ack = ata_irq_ack, | ||
376 | 372 | ||
377 | .port_start = ata_port_start, | 373 | .port_start = ata_port_start, |
378 | }; | 374 | }; |
@@ -439,7 +435,6 @@ static struct ata_port_operations ht6560b_port_ops = { | |||
439 | .irq_handler = ata_interrupt, | 435 | .irq_handler = ata_interrupt, |
440 | .irq_clear = ata_bmdma_irq_clear, | 436 | .irq_clear = ata_bmdma_irq_clear, |
441 | .irq_on = ata_irq_on, | 437 | .irq_on = ata_irq_on, |
442 | .irq_ack = ata_irq_ack, | ||
443 | 438 | ||
444 | .port_start = ata_port_start, | 439 | .port_start = ata_port_start, |
445 | }; | 440 | }; |
@@ -561,7 +556,6 @@ static struct ata_port_operations opti82c611a_port_ops = { | |||
561 | .irq_handler = ata_interrupt, | 556 | .irq_handler = ata_interrupt, |
562 | .irq_clear = ata_bmdma_irq_clear, | 557 | .irq_clear = ata_bmdma_irq_clear, |
563 | .irq_on = ata_irq_on, | 558 | .irq_on = ata_irq_on, |
564 | .irq_ack = ata_irq_ack, | ||
565 | 559 | ||
566 | .port_start = ata_port_start, | 560 | .port_start = ata_port_start, |
567 | }; | 561 | }; |
@@ -695,7 +689,6 @@ static struct ata_port_operations opti82c46x_port_ops = { | |||
695 | .irq_handler = ata_interrupt, | 689 | .irq_handler = ata_interrupt, |
696 | .irq_clear = ata_bmdma_irq_clear, | 690 | .irq_clear = ata_bmdma_irq_clear, |
697 | .irq_on = ata_irq_on, | 691 | .irq_on = ata_irq_on, |
698 | .irq_ack = ata_irq_ack, | ||
699 | 692 | ||
700 | .port_start = ata_port_start, | 693 | .port_start = ata_port_start, |
701 | }; | 694 | }; |