libata: update libata LLDs to use devres

Update libata LLDs to use devres.  Core layer is already converted to
support managed LLDs.  This patch simplifies initialization and fixes
many resource related bugs in init failure and detach path.  For
example, all converted drivers now handle ata_device_add() failure
gracefully without excessive resource rollback code.

As most resources are released automatically on driver detach, many
drivers don't need or can do with much simpler ->{port|host}_stop().
In general, stop callbacks are need iff port or host needs to be given
commands to shut it down.  Note that freezing is enough in many cases
and ports are automatically frozen before being detached.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

1 files changed, 3 insertions, 25 deletions

diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index 171fbd206bd5..f23365b92c0f 100644
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -594,14 +594,10 @@ static int it821x_port_start(struct ata_port *ap)
         if (ret < 0)
                 return ret;
 
-        ap->private_data = kmalloc(sizeof(struct it821x_dev), GFP_KERNEL);
-        if (ap->private_data == NULL) {
-                ata_port_stop(ap);
+        itdev = devm_kzalloc(&pdev->dev, sizeof(struct it821x_dev), GFP_KERNEL);
+        if (itdev == NULL)
                 return -ENOMEM;
-        }
-
-        itdev = ap->private_data;
-        memset(itdev, 0, sizeof(struct it821x_dev));
+        ap->private_data = itdev;
 
         pci_read_config_byte(pdev, 0x50, &conf);
 
@@ -632,20 +628,6 @@ static int it821x_port_start(struct ata_port *ap)
         return 0;
 }
 
-/**
- *      it821x_port_stop        -       port shutdown
- *      @ap: ATA port being removed
- *
- *      Release the private objects we added in it821x_port_start
- */
-
-static void it821x_port_stop(struct ata_port *ap) {
-        kfree(ap->private_data);
-        ap->private_data = NULL;        /* We want an OOPS if we reuse this
-                                           too late! */
-        ata_port_stop(ap);
-}
-
 static struct scsi_host_template it821x_sht = {
         .module                 = THIS_MODULE,
         .name                   = DRV_NAME,
@@ -698,8 +680,6 @@ static struct ata_port_operations it821x_smart_port_ops = {
         .irq_clear      = ata_bmdma_irq_clear,
 
         .port_start     = it821x_port_start,
-        .port_stop      = it821x_port_stop,
-        .host_stop      = ata_host_stop
 };
 
 static struct ata_port_operations it821x_passthru_port_ops = {
@@ -734,8 +714,6 @@ static struct ata_port_operations it821x_passthru_port_ops = {
         .irq_handler    = ata_interrupt,
 
         .port_start     = it821x_port_start,
-        .port_stop      = it821x_port_stop,
-        .host_stop      = ata_host_stop
 };
 
 static void __devinit it821x_disable_raid(struct pci_dev *pdev)