diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/pata_efar.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_efar.c')
-rw-r--r-- | drivers/ata/pata_efar.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/pata_efar.c b/drivers/ata/pata_efar.c index a08834758ea2..aca47e4e29ea 100644 --- a/drivers/ata/pata_efar.c +++ b/drivers/ata/pata_efar.c | |||
@@ -263,7 +263,6 @@ static struct ata_port_operations efar_ops = { | |||
263 | 263 | ||
264 | static int efar_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) | 264 | static int efar_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) |
265 | { | 265 | { |
266 | static int printed_version; | ||
267 | static const struct ata_port_info info = { | 266 | static const struct ata_port_info info = { |
268 | .flags = ATA_FLAG_SLAVE_POSS, | 267 | .flags = ATA_FLAG_SLAVE_POSS, |
269 | .pio_mask = ATA_PIO4, | 268 | .pio_mask = ATA_PIO4, |
@@ -273,9 +272,7 @@ static int efar_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) | |||
273 | }; | 272 | }; |
274 | const struct ata_port_info *ppi[] = { &info, &info }; | 273 | const struct ata_port_info *ppi[] = { &info, &info }; |
275 | 274 | ||
276 | if (!printed_version++) | 275 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
277 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
278 | "version " DRV_VERSION "\n"); | ||
279 | 276 | ||
280 | return ata_pci_bmdma_init_one(pdev, ppi, &efar_sht, NULL, | 277 | return ata_pci_bmdma_init_one(pdev, ppi, &efar_sht, NULL, |
281 | ATA_HOST_PARALLEL_SCAN); | 278 | ATA_HOST_PARALLEL_SCAN); |