diff options
author | Tejun Heo <htejun@gmail.com> | 2008-03-24 23:22:48 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:17 -0400 |
commit | 6bd99b4e0998571808fc1f09d5162348f21ff8c1 (patch) | |
tree | e338bd445aaa5cda4bbf1f5598acf70f0d6b68de /drivers/ata/pata_cmd64x.c | |
parent | 358f9a77a668660729e705fde9c3cf69f013aa98 (diff) |
libata: normalize port_info, port_operations and sht tables
Over the time, port info, ops and sht structures developed quite a bit
of inconsistencies. This patch updates drivers.
* Enable/disable_pm callbacks added to all ahci ops tables.
* Every driver for SFF controllers now uses ata_sff_port_start()
instead of ata_port_start() unless the driver has custom
implementation.
* Every driver for SFF controllers now uses ata_pci_default_filter()
unless the driver has custom implementation.
* Removed an odd port_info->sht initialization from ata_piix.c.
Likely a merge byproduct.
* A port which has ATA_FLAG_SATA set doesn't need to set cable_detect
to ata_cable_sata(). Remove it from via and mv port ops.
* Some drivers had unnecessary .max_sectors initialization which is
ignored and was missing .slave_destroy callback. Fixed.
* Removed unnecessary sht initializations port_info's.
* Removed onsolete scsi device suspend/resume callbacks from
pata_bf54x.
* No reason to set ata_pci_default_filter() and bmdma functions for
PIO-only drivers. Remove those callbacks and replace
ata_bmdma_irq_clear with ata_noop_irq_clear.
* pata_platform sets port_start to ata_dummy_ret0. port_start can
just be set to NULL.
* sata_fsl supports NCQ but was missing qc_defer. Fixed.
* pata_rb600_cf implements dummy port_start. Removed.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_cmd64x.c')
-rw-r--r-- | drivers/ata/pata_cmd64x.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/ata/pata_cmd64x.c b/drivers/ata/pata_cmd64x.c index 1c9a8d97f874..e8c1262341ee 100644 --- a/drivers/ata/pata_cmd64x.c +++ b/drivers/ata/pata_cmd64x.c | |||
@@ -313,7 +313,7 @@ static struct ata_port_operations cmd64x_port_ops = { | |||
313 | .irq_clear = ata_bmdma_irq_clear, | 313 | .irq_clear = ata_bmdma_irq_clear, |
314 | .irq_on = ata_irq_on, | 314 | .irq_on = ata_irq_on, |
315 | 315 | ||
316 | .port_start = ata_port_start, | 316 | .port_start = ata_sff_port_start, |
317 | }; | 317 | }; |
318 | 318 | ||
319 | static struct ata_port_operations cmd646r1_port_ops = { | 319 | static struct ata_port_operations cmd646r1_port_ops = { |
@@ -346,7 +346,7 @@ static struct ata_port_operations cmd646r1_port_ops = { | |||
346 | .irq_clear = ata_bmdma_irq_clear, | 346 | .irq_clear = ata_bmdma_irq_clear, |
347 | .irq_on = ata_irq_on, | 347 | .irq_on = ata_irq_on, |
348 | 348 | ||
349 | .port_start = ata_port_start, | 349 | .port_start = ata_sff_port_start, |
350 | }; | 350 | }; |
351 | 351 | ||
352 | static struct ata_port_operations cmd648_port_ops = { | 352 | static struct ata_port_operations cmd648_port_ops = { |
@@ -379,7 +379,7 @@ static struct ata_port_operations cmd648_port_ops = { | |||
379 | .irq_clear = ata_bmdma_irq_clear, | 379 | .irq_clear = ata_bmdma_irq_clear, |
380 | .irq_on = ata_irq_on, | 380 | .irq_on = ata_irq_on, |
381 | 381 | ||
382 | .port_start = ata_port_start, | 382 | .port_start = ata_sff_port_start, |
383 | }; | 383 | }; |
384 | 384 | ||
385 | static int cmd64x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) | 385 | static int cmd64x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) |