diff options
author | Tejun Heo <htejun@gmail.com> | 2008-04-07 09:47:16 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:21 -0400 |
commit | 9363c3825ea9ad76561eb48a395349dd29211ed6 (patch) | |
tree | abe89a0f7c82b805d84b1a211c97b317f6628d5f /drivers/ata/pata_cmd640.c | |
parent | b67a1064cb1c1d3b43e01e8b43a6a8dcdefed733 (diff) |
libata: rename SFF functions
SFF functions have confusing names. Some have sff prefix, some have
bmdma, some std, some pci and some none. Unify the naming by...
* SFF functions which are common to both BMDMA and non-BMDMA are
prefixed with ata_sff_.
* SFF functions which are specific to BMDMA are prefixed with
ata_bmdma_.
* SFF functions which are specific to PCI but apply to both BMDMA and
non-BMDMA are prefixed with ata_pci_sff_.
* SFF functions which are specific to PCI and BMDMA are prefixed with
ata_pci_bmdma_.
* Drop generic prefixes from LLD specific routines. For example,
bfin_std_dev_select -> bfin_dev_select.
The following renames are noteworthy.
ata_qc_issue_prot() -> ata_sff_qc_issue()
ata_pci_default_filter() -> ata_bmdma_mode_filter()
ata_dev_try_classify() -> ata_sff_dev_classify()
This rename is in preparation of separating SFF support out of libata
core layer. This patch strictly renames functions and doesn't
introduce any behavior difference.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_cmd640.c')
-rw-r--r-- | drivers/ata/pata_cmd640.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/ata/pata_cmd640.c b/drivers/ata/pata_cmd640.c index 27219b00edf4..a907cf478891 100644 --- a/drivers/ata/pata_cmd640.c +++ b/drivers/ata/pata_cmd640.c | |||
@@ -107,8 +107,8 @@ static void cmd640_set_piomode(struct ata_port *ap, struct ata_device *adev) | |||
107 | pci_write_config_byte(pdev, arttim + 1, (t.active << 4) | t.recover); | 107 | pci_write_config_byte(pdev, arttim + 1, (t.active << 4) | t.recover); |
108 | } else { | 108 | } else { |
109 | /* Save the shared timings for channel, they will be loaded | 109 | /* Save the shared timings for channel, they will be loaded |
110 | by qc_issue_prot. Reloading the setup time is expensive | 110 | by qc_issue. Reloading the setup time is expensive so we |
111 | so we keep a merged one loaded */ | 111 | keep a merged one loaded */ |
112 | pci_read_config_byte(pdev, ARTIM23, ®); | 112 | pci_read_config_byte(pdev, ARTIM23, ®); |
113 | reg &= 0x3F; | 113 | reg &= 0x3F; |
114 | reg |= t.setup; | 114 | reg |= t.setup; |
@@ -119,14 +119,14 @@ static void cmd640_set_piomode(struct ata_port *ap, struct ata_device *adev) | |||
119 | 119 | ||
120 | 120 | ||
121 | /** | 121 | /** |
122 | * cmd640_qc_issue_prot - command preparation hook | 122 | * cmd640_qc_issue - command preparation hook |
123 | * @qc: Command to be issued | 123 | * @qc: Command to be issued |
124 | * | 124 | * |
125 | * Channel 1 has shared timings. We must reprogram the | 125 | * Channel 1 has shared timings. We must reprogram the |
126 | * clock each drive 2/3 switch we do. | 126 | * clock each drive 2/3 switch we do. |
127 | */ | 127 | */ |
128 | 128 | ||
129 | static unsigned int cmd640_qc_issue_prot(struct ata_queued_cmd *qc) | 129 | static unsigned int cmd640_qc_issue(struct ata_queued_cmd *qc) |
130 | { | 130 | { |
131 | struct ata_port *ap = qc->ap; | 131 | struct ata_port *ap = qc->ap; |
132 | struct ata_device *adev = qc->dev; | 132 | struct ata_device *adev = qc->dev; |
@@ -137,7 +137,7 @@ static unsigned int cmd640_qc_issue_prot(struct ata_queued_cmd *qc) | |||
137 | pci_write_config_byte(pdev, DRWTIM23, timing->reg58[adev->devno]); | 137 | pci_write_config_byte(pdev, DRWTIM23, timing->reg58[adev->devno]); |
138 | timing->last = adev->devno; | 138 | timing->last = adev->devno; |
139 | } | 139 | } |
140 | return ata_qc_issue_prot(qc); | 140 | return ata_sff_qc_issue(qc); |
141 | } | 141 | } |
142 | 142 | ||
143 | /** | 143 | /** |
@@ -172,8 +172,8 @@ static struct scsi_host_template cmd640_sht = { | |||
172 | static struct ata_port_operations cmd640_port_ops = { | 172 | static struct ata_port_operations cmd640_port_ops = { |
173 | .inherits = &ata_bmdma_port_ops, | 173 | .inherits = &ata_bmdma_port_ops, |
174 | /* In theory xfer_noirq is not needed once we kill the prefetcher */ | 174 | /* In theory xfer_noirq is not needed once we kill the prefetcher */ |
175 | .data_xfer = ata_data_xfer_noirq, | 175 | .data_xfer = ata_sff_data_xfer_noirq, |
176 | .qc_issue = cmd640_qc_issue_prot, | 176 | .qc_issue = cmd640_qc_issue, |
177 | .cable_detect = ata_cable_40wire, | 177 | .cable_detect = ata_cable_40wire, |
178 | .set_piomode = cmd640_set_piomode, | 178 | .set_piomode = cmd640_set_piomode, |
179 | .port_start = cmd640_port_start, | 179 | .port_start = cmd640_port_start, |
@@ -224,7 +224,7 @@ static int cmd640_init_one(struct pci_dev *pdev, const struct pci_device_id *id) | |||
224 | 224 | ||
225 | cmd640_hardware_init(pdev); | 225 | cmd640_hardware_init(pdev); |
226 | 226 | ||
227 | return ata_pci_init_one(pdev, ppi, &cmd640_sht, NULL); | 227 | return ata_pci_sff_init_one(pdev, ppi, &cmd640_sht, NULL); |
228 | } | 228 | } |
229 | 229 | ||
230 | #ifdef CONFIG_PM | 230 | #ifdef CONFIG_PM |