diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/pata_artop.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_artop.c')
-rw-r--r-- | drivers/ata/pata_artop.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c index 2215632e4b31..78a93b690959 100644 --- a/drivers/ata/pata_artop.c +++ b/drivers/ata/pata_artop.c | |||
@@ -346,7 +346,6 @@ static struct ata_port_operations artop6260_ops = { | |||
346 | 346 | ||
347 | static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id) | 347 | static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id) |
348 | { | 348 | { |
349 | static int printed_version; | ||
350 | static const struct ata_port_info info_6210 = { | 349 | static const struct ata_port_info info_6210 = { |
351 | .flags = ATA_FLAG_SLAVE_POSS, | 350 | .flags = ATA_FLAG_SLAVE_POSS, |
352 | .pio_mask = ATA_PIO4, | 351 | .pio_mask = ATA_PIO4, |
@@ -378,9 +377,7 @@ static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id) | |||
378 | const struct ata_port_info *ppi[] = { NULL, NULL }; | 377 | const struct ata_port_info *ppi[] = { NULL, NULL }; |
379 | int rc; | 378 | int rc; |
380 | 379 | ||
381 | if (!printed_version++) | 380 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
382 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
383 | "version " DRV_VERSION "\n"); | ||
384 | 381 | ||
385 | rc = pcim_enable_device(pdev); | 382 | rc = pcim_enable_device(pdev); |
386 | if (rc) | 383 | if (rc) |