aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/libata-sff.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-11-16 22:06:21 -0500
committerTejun Heo <htejun@gmail.com>2006-12-03 03:56:24 -0500
commitea54763f8a7c51b9f8fcb14431812ae63fcbaf96 (patch)
tree913b24b4f58cec489e9939f4afbfe51f82f237a9 /drivers/ata/libata-sff.c
parentf84e7e41e1b88547218a3c3b1eb528005e9afdb4 (diff)
[PATCH] libata: move BMDMA host status recording from EH to interrupt handler
For certain errors, interrupt handler alter BMDMA host status before entering EH (clears active and intr). Thus altered BMDMA host status value is recorded by BMDMA EH and reported to user. Move BMDMA host status recording from EH to interrupt handler. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/libata-sff.c')
-rw-r--r--drivers/ata/libata-sff.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index a57de4a5aa45..95ff186f0ccd 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -743,7 +743,6 @@ void ata_bmdma_drive_eh(struct ata_port *ap, ata_prereset_fn_t prereset,
743 ata_reset_fn_t softreset, ata_reset_fn_t hardreset, 743 ata_reset_fn_t softreset, ata_reset_fn_t hardreset,
744 ata_postreset_fn_t postreset) 744 ata_postreset_fn_t postreset)
745{ 745{
746 struct ata_eh_context *ehc = &ap->eh_context;
747 struct ata_queued_cmd *qc; 746 struct ata_queued_cmd *qc;
748 unsigned long flags; 747 unsigned long flags;
749 int thaw = 0; 748 int thaw = 0;
@@ -763,8 +762,6 @@ void ata_bmdma_drive_eh(struct ata_port *ap, ata_prereset_fn_t prereset,
763 762
764 host_stat = ap->ops->bmdma_status(ap); 763 host_stat = ap->ops->bmdma_status(ap);
765 764
766 ata_ehi_push_desc(&ehc->i, "BMDMA stat 0x%x", host_stat);
767
768 /* BMDMA controllers indicate host bus error by 765 /* BMDMA controllers indicate host bus error by
769 * setting DMA_ERR bit and timing out. As it wasn't 766 * setting DMA_ERR bit and timing out. As it wasn't
770 * really a timeout event, adjust error mask and 767 * really a timeout event, adjust error mask and