diff options
author | Tejun Heo <htejun@gmail.com> | 2008-04-07 09:47:17 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:22 -0400 |
commit | 288623a06c652239d2f57d271af12bb024cf7218 (patch) | |
tree | e693ca8a46cbedc522cb6f5ca3395d3dc692cfb3 /drivers/ata/libata-sff.c | |
parent | 5682ed33aae05d10a25c95633ef9d9c062825888 (diff) |
libata: clean up port_ops->sff_irq_clear()
->sff_irq_clear() is called only from SFF interrupt handler, so there
is no reason to initialize it for non-SFF controllers. Also,
ata_sff_irq_clear() can handle both BMDMA and non-BMDMA SFF
controllers.
This patch kills ata_noop_irq_clear() and removes it from base
port_ops and sets ->sff_irq_clear to ata_sff_irq_clear() in sff
port_ops instead of bmdma port_ops.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/libata-sff.c')
-rw-r--r-- | drivers/ata/libata-sff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 04024a556660..c11601617134 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c | |||
@@ -58,6 +58,7 @@ const struct ata_port_operations ata_sff_port_ops = { | |||
58 | .sff_exec_command = ata_sff_exec_command, | 58 | .sff_exec_command = ata_sff_exec_command, |
59 | .sff_data_xfer = ata_sff_data_xfer, | 59 | .sff_data_xfer = ata_sff_data_xfer, |
60 | .sff_irq_on = ata_sff_irq_on, | 60 | .sff_irq_on = ata_sff_irq_on, |
61 | .sff_irq_clear = ata_sff_irq_clear, | ||
61 | 62 | ||
62 | .port_start = ata_sff_port_start, | 63 | .port_start = ata_sff_port_start, |
63 | }; | 64 | }; |
@@ -71,7 +72,6 @@ const struct ata_port_operations ata_bmdma_port_ops = { | |||
71 | .bmdma_start = ata_bmdma_start, | 72 | .bmdma_start = ata_bmdma_start, |
72 | .bmdma_stop = ata_bmdma_stop, | 73 | .bmdma_stop = ata_bmdma_stop, |
73 | .bmdma_status = ata_bmdma_status, | 74 | .bmdma_status = ata_bmdma_status, |
74 | .sff_irq_clear = ata_sff_irq_clear, | ||
75 | }; | 75 | }; |
76 | 76 | ||
77 | /** | 77 | /** |