diff options
author | Hannes Reinecke <hare@suse.de> | 2015-03-27 11:46:35 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2015-03-27 11:59:22 -0400 |
commit | 42b966fbf35da9c87f08d98f9b8978edf9e717cf (patch) | |
tree | a7fd32da1b3a746cab71966d42a08aeeb0d7203d /drivers/ata/libata-scsi.c | |
parent | 1308d7f0107b264b480e7048dc345fc6b7408e7e (diff) |
libata: Implement NCQ autosense
Some newer devices support NCQ autosense (cf ACS-4), so we should
be using it to retrieve the sense code and speed up recovery.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/libata-scsi.c')
-rw-r--r-- | drivers/ata/libata-scsi.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bb57d81083ca..3ac5be3acdbe 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c | |||
@@ -270,8 +270,11 @@ DEVICE_ATTR(unload_heads, S_IRUGO | S_IWUSR, | |||
270 | ata_scsi_park_show, ata_scsi_park_store); | 270 | ata_scsi_park_show, ata_scsi_park_store); |
271 | EXPORT_SYMBOL_GPL(dev_attr_unload_heads); | 271 | EXPORT_SYMBOL_GPL(dev_attr_unload_heads); |
272 | 272 | ||
273 | static void ata_scsi_set_sense(struct scsi_cmnd *cmd, u8 sk, u8 asc, u8 ascq) | 273 | void ata_scsi_set_sense(struct scsi_cmnd *cmd, u8 sk, u8 asc, u8 ascq) |
274 | { | 274 | { |
275 | if (!cmd) | ||
276 | return; | ||
277 | |||
275 | cmd->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION; | 278 | cmd->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION; |
276 | 279 | ||
277 | scsi_build_sense_buffer(0, cmd->sense_buffer, sk, asc, ascq); | 280 | scsi_build_sense_buffer(0, cmd->sense_buffer, sk, asc, ascq); |
@@ -1777,7 +1780,9 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc) | |||
1777 | ((cdb[2] & 0x20) || need_sense)) { | 1780 | ((cdb[2] & 0x20) || need_sense)) { |
1778 | ata_gen_passthru_sense(qc); | 1781 | ata_gen_passthru_sense(qc); |
1779 | } else { | 1782 | } else { |
1780 | if (!need_sense) { | 1783 | if (qc->flags & ATA_QCFLAG_SENSE_VALID) { |
1784 | cmd->result = SAM_STAT_CHECK_CONDITION; | ||
1785 | } else if (!need_sense) { | ||
1781 | cmd->result = SAM_STAT_GOOD; | 1786 | cmd->result = SAM_STAT_GOOD; |
1782 | } else { | 1787 | } else { |
1783 | /* TODO: decide which descriptor format to use | 1788 | /* TODO: decide which descriptor format to use |