diff options
author | Tejun Heo <htejun@gmail.com> | 2008-05-18 12:15:07 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-05-19 17:51:47 -0400 |
commit | dc98c32cbe80750ae2d9d9fbdae305d38f005de7 (patch) | |
tree | 52bff671e5ed5b39056bb4a5c531476c83e9f708 /drivers/ata/libata-pmp.c | |
parent | 932648b007de76badc61c1b13d7282288dbe887e (diff) |
libata: move reset freeze/thaw handling into ata_eh_reset()
Previously reset freeze/thaw handling lived outside of ata_eh_reset()
mainly because the original PMP reset code needed the port frozen
while resetting all the fan-out ports, which is no longer the case.
This patch moves freeze/thaw handling into ata_eh_reset().
@prereset() and @postreset() are now called w/o freezing the port
although @prereset() an be called frozen if the port is frozen prior
to entering ata_eh_reset().
This makes code simpler and will help removing hotplug event related
races.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata/libata-pmp.c')
-rw-r--r-- | drivers/ata/libata-pmp.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index ff1822a7da38..f3ad024394c2 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c | |||
@@ -700,8 +700,6 @@ static int sata_pmp_eh_recover_pmp(struct ata_port *ap, | |||
700 | if (ehc->i.action & ATA_EH_RESET) { | 700 | if (ehc->i.action & ATA_EH_RESET) { |
701 | struct ata_link *tlink; | 701 | struct ata_link *tlink; |
702 | 702 | ||
703 | ata_eh_freeze_port(ap); | ||
704 | |||
705 | /* reset */ | 703 | /* reset */ |
706 | rc = ata_eh_reset(link, 0, prereset, softreset, hardreset, | 704 | rc = ata_eh_reset(link, 0, prereset, softreset, hardreset, |
707 | postreset); | 705 | postreset); |
@@ -711,8 +709,6 @@ static int sata_pmp_eh_recover_pmp(struct ata_port *ap, | |||
711 | goto fail; | 709 | goto fail; |
712 | } | 710 | } |
713 | 711 | ||
714 | ata_eh_thaw_port(ap); | ||
715 | |||
716 | /* PMP is reset, SErrors cannot be trusted, scan all */ | 712 | /* PMP is reset, SErrors cannot be trusted, scan all */ |
717 | ata_port_for_each_link(tlink, ap) { | 713 | ata_port_for_each_link(tlink, ap) { |
718 | struct ata_eh_context *ehc = &tlink->eh_context; | 714 | struct ata_eh_context *ehc = &tlink->eh_context; |