libata: kill ata_ehi_schedule_probe()

ata_ehi_schedule_probe() was created to hide details of link-resuming
reset magic.  Now that all the softreset workarounds are gone,
scheduling probe is very simple - set probe_mask and request RESET.
Kill ata_ehi_schedule_probe() and open code it.  This also increases
consistency as ata_ehi_schedule_probe() couldn't cover individual
device probings so they were open-coded even when the helper existed.

While at it, define ATA_ALL_DEVICES as mask of all possible devices on
a link and always use it when requesting probe on link level for
simplicity and consistency.  Setting extra bits in the probe_mask
doesn't hurt anybody.

Signed-off-by: Tejun Heo <htejun@gmail.com>

1 files changed, 8 insertions, 4 deletions

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index df1d3252b9e6..39e036c8a2bc 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -435,7 +435,7 @@ static int sata_pmp_init_links(struct ata_port *ap, int nr_ports)
                 struct ata_eh_context *ehc = &link->eh_context;
 
                 link->flags = 0;
-                ehc->i.probe_mask |= 1;
+                ehc->i.probe_mask |= ATA_ALL_DEVICES;
                 ehc->i.action |= ATA_EH_RESET;
         }
 
@@ -831,8 +831,12 @@ static int sata_pmp_eh_recover_pmp(struct ata_port *ap,
                 ata_eh_thaw_port(ap);
 
                 /* PMP is reset, SErrors cannot be trusted, scan all */
-                ata_port_for_each_link(tlink, ap)
-                        ata_ehi_schedule_probe(&tlink->eh_context.i);
+                ata_port_for_each_link(tlink, ap) {
+                        struct ata_eh_context *ehc = &tlink->eh_context;
+
+                        ehc->i.probe_mask |= ATA_ALL_DEVICES;
+                        ehc->i.action |= ATA_EH_RESET;
+                }
         }
 
         /* If revalidation is requested, revalidate and reconfigure;
@@ -847,7 +851,7 @@ static int sata_pmp_eh_recover_pmp(struct ata_port *ap,
                 tries--;
 
                 if (rc == -ENODEV) {
-                        ehc->i.probe_mask |= 1;
+                        ehc->i.probe_mask |= ATA_ALL_DEVICES;
                         detach = 1;
                         /* give it just two more chances */
                         tries = min(tries, 2);