aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/libata-eh.c
diff options
context:
space:
mode:
authorWolfram Sang <wsa@the-dreams.de>2013-11-14 17:32:02 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2013-11-14 19:32:21 -0500
commit16735d022f72b20ddbb2274b8e109f69575e9b2b (patch)
treef567c7dfff06ae18899feab7cd8a79a7a0f7be40 /drivers/ata/libata-eh.c
parentc32f74ab2872994bc8336ed367313da3139350ca (diff)
tree-wide: use reinit_completion instead of INIT_COMPLETION
Use this new function to make code more comprehensible, since we are reinitialzing the completion, not initializing. [akpm@linux-foundation.org: linux-next resyncs] Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) Cc: Ingo Molnar <mingo@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/ata/libata-eh.c')
-rw-r--r--drivers/ata/libata-eh.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 77bbc8266883..92d7797223be 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -3017,7 +3017,7 @@ static inline void ata_eh_pull_park_action(struct ata_port *ap)
3017 * ourselves at the beginning of each pass over the loop. 3017 * ourselves at the beginning of each pass over the loop.
3018 * 3018 *
3019 * Additionally, all write accesses to &ap->park_req_pending 3019 * Additionally, all write accesses to &ap->park_req_pending
3020 * through INIT_COMPLETION() (see below) or complete_all() 3020 * through reinit_completion() (see below) or complete_all()
3021 * (see ata_scsi_park_store()) are protected by the host lock. 3021 * (see ata_scsi_park_store()) are protected by the host lock.
3022 * As a result we have that park_req_pending.done is zero on 3022 * As a result we have that park_req_pending.done is zero on
3023 * exit from this function, i.e. when ATA_EH_PARK actions for 3023 * exit from this function, i.e. when ATA_EH_PARK actions for
@@ -3031,7 +3031,7 @@ static inline void ata_eh_pull_park_action(struct ata_port *ap)
3031 */ 3031 */
3032 3032
3033 spin_lock_irqsave(ap->lock, flags); 3033 spin_lock_irqsave(ap->lock, flags);
3034 INIT_COMPLETION(ap->park_req_pending); 3034 reinit_completion(&ap->park_req_pending);
3035 ata_for_each_link(link, ap, EDGE) { 3035 ata_for_each_link(link, ap, EDGE) {
3036 ata_for_each_dev(dev, link, ALL) { 3036 ata_for_each_dev(dev, link, ALL) {
3037 struct ata_eh_info *ehi = &link->eh_info; 3037 struct ata_eh_info *ehi = &link->eh_info;