diff options
author | Tejun Heo <htejun@gmail.com> | 2007-10-25 05:30:36 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-29 06:15:25 -0400 |
commit | 054a5fbaceb2eb3a31ea843c1cf0b8e10b91478c (patch) | |
tree | cbf21985f3894b11fe00666cef8ac33bae4f007d /drivers/ata/libata-eh.c | |
parent | 4dbfa39b6c95eb9d0aedb5bd00bb552b91c31e3d (diff) |
libata: track SLEEP state and issue SRST to wake it up
ATA devices in SLEEP mode don't respond to any commands. SRST is
necessary to wake it up. Till now, when a command is issued to a
device in SLEEP mode, the command times out, which makes EH reset the
device and retry the command after that, causing a long delay.
This patch makes libata track SLEEP state and issue SRST automatically
if a command is about to be issued to a device in SLEEP.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Bruce Allen <ballen@gravity.phys.uwm.edu>
Cc: Andrew Paprocki <andrew@ishiboo.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/libata-eh.c')
-rw-r--r-- | drivers/ata/libata-eh.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 8cb35bb87605..496edaff119a 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c | |||
@@ -2208,9 +2208,11 @@ int ata_eh_reset(struct ata_link *link, int classify, | |||
2208 | ata_link_for_each_dev(dev, link) { | 2208 | ata_link_for_each_dev(dev, link) { |
2209 | /* After the reset, the device state is PIO 0 | 2209 | /* After the reset, the device state is PIO 0 |
2210 | * and the controller state is undefined. | 2210 | * and the controller state is undefined. |
2211 | * Record the mode. | 2211 | * Reset also wakes up drives from sleeping |
2212 | * mode. | ||
2212 | */ | 2213 | */ |
2213 | dev->pio_mode = XFER_PIO_0; | 2214 | dev->pio_mode = XFER_PIO_0; |
2215 | dev->flags &= ~ATA_DFLAG_SLEEPING; | ||
2214 | 2216 | ||
2215 | if (ata_link_offline(link)) | 2217 | if (ata_link_offline(link)) |
2216 | continue; | 2218 | continue; |