libata: move generic hardreset code from sata_sff_hardreset() to sata_link_hardreset()

sata_sff_hardreset() contains link readiness wait logic which isn't
SFF specific.  Move that part into sata_link_hardreset(), which now
takes two more parameters - @online and @check_ready.  Both are
optional.  The former is out parameter for link onlineness after
reset.  The latter is used to wait for link readiness after hardreset.

Users of sata_link_hardreset() is updated to use new funtionality and
ahci_hardreset() is updated to use sata_link_hardreset() instead of
sata_sff_hardreset().  This doesn't really cause any behavior change.

Signed-off-by: Tejun Heo <htejun@gmail.com>

1 files changed, 49 insertions, 1 deletions

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 3bad6f189190..b607292b6480 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3557,8 +3557,18 @@ int ata_std_prereset(struct ata_link *link, unsigned long deadline)
  *      @link: link to reset
  *      @timing: timing parameters { interval, duratinon, timeout } in msec
  *      @deadline: deadline jiffies for the operation
+ *      @online: optional out parameter indicating link onlineness
+ *      @check_ready: optional callback to check link readiness
  *
  *      SATA phy-reset @link using DET bits of SControl register.
+ *      After hardreset, link readiness is waited upon using
+ *      ata_wait_ready() if @check_ready is specified.  LLDs are
+ *      allowed to not specify @check_ready and wait itself after this
+ *      function returns.  Device classification is LLD's
+ *      responsibility.
+ *
+ *      *@online is set to one iff reset succeeded and @link is online
+ *      after reset.
  *
  *      LOCKING:
  *      Kernel thread context (may sleep)
@@ -3567,13 +3577,17 @@ int ata_std_prereset(struct ata_link *link, unsigned long deadline)
  *      0 on success, -errno otherwise.
  */
 int sata_link_hardreset(struct ata_link *link, const unsigned long *timing,
-                        unsigned long deadline)
+                        unsigned long deadline,
+                        bool *online, int (*check_ready)(struct ata_link *))
 {
         u32 scontrol;
         int rc;
 
         DPRINTK("ENTER\n");
 
+        if (online)
+                *online = false;
+
         if (sata_set_spd_needed(link)) {
                 /* SATA spec says nothing about how to reconfigure
                  * spd.  To be on the safe side, turn off phy during
@@ -3607,7 +3621,41 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing,
 
         /* bring link back */
         rc = sata_link_resume(link, timing, deadline);
+        if (rc)
+                goto out;
+        /* if link is offline nothing more to do */
+        if (ata_link_offline(link))
+                goto out;
+
+        /* Link is online.  From this point, -ENODEV too is an error. */
+        if (online)
+                *online = true;
+
+        if ((link->ap->flags & ATA_FLAG_PMP) && ata_is_host_link(link)) {
+                /* If PMP is supported, we have to do follow-up SRST.
+                 * Some PMPs don't send D2H Reg FIS after hardreset if
+                 * the first port is empty.  Wait only for
+                 * ATA_TMOUT_PMP_SRST_WAIT.
+                 */
+                if (check_ready) {
+                        unsigned long pmp_deadline;
+
+                        pmp_deadline = jiffies + ATA_TMOUT_PMP_SRST_WAIT;
+                        if (time_after(pmp_deadline, deadline))
+                                pmp_deadline = deadline;
+                        ata_wait_ready(link, pmp_deadline, check_ready);
+                }
+                rc = -EAGAIN;
+                goto out;
+        }
+
+        rc = 0;
+        if (check_ready)
+                rc = ata_wait_ready(link, deadline, check_ready);
  out:
+        if (rc && rc != -EAGAIN)
+                ata_link_printk(link, KERN_ERR,
+                                "COMRESET failed (errno=%d)\n", rc);
         DPRINTK("EXIT, rc=%d\n", rc);
         return rc;
 }