Merge branch 'for-3.20/drivers' of git://git.kernel.dk/linux-block

Pull block driver changes from Jens Axboe:
 "This contains:

   - The 4k/partition fixes for brd from Boaz/Matthew.

   - A few xen front/back block fixes from David Vrabel and Roger Pau
     Monne.

   - Floppy changes from Takashi, cleaning the device file creation.

   - Switching libata to use the new blk-mq tagging policy, removing
     code (and a suboptimal implementation) from libata.  This will
     throw you a merge conflict, since a bug in the original libata
     tagging code was fixed since this code was branched.  Trivial.
     From Shaohua.

   - Conversion of loop to blk-mq, from Ming Lei.

   - Cleanup of the io_schedule() handling in bsg from Peter Zijlstra.
     He claims it improves on unreadable code, which will cost him a
     beer.

   - Maintainer update or NDB, now handled by Markus Pargmann.

   - NVMe:
        - Optimization from me that avoids a kmalloc/kfree per IO for
          smaller (<= 8KB) IO. This cuts about 1% of high IOPS CPU
          overhead.
        - Removal of (now) dead RCU code, a relic from before NVMe was
          converted to blk-mq"

* 'for-3.20/drivers' of git://git.kernel.dk/linux-block:
  xen-blkback: default to X86_32 ABI on x86
  xen-blkfront: fix accounting of reqs when migrating
  xen-blkback,xen-blkfront: add myself as maintainer
  block: Simplify bsg complete all
  floppy: Avoid manual call of device_create_file()
  NVMe: avoid kmalloc/kfree for smaller IO
  MAINTAINERS: Update NBD maintainer
  libata: make sata_sil24 use fifo tag allocator
  libata: move sas ata tag allocation to libata-scsi.c
  libata: use blk taging
  NVMe: within nvme_free_queues(), delete RCU sychro/deferred free
  null_blk: suppress invalid partition info
  brd: Request from fdisk 4k alignment
  brd: Fix all partitions BUGs
  axonram: Fix bug in direct_access
  loop: add blk-mq.h include
  block: loop: don't handle REQ_FUA explicitly
  block: loop: introduce lo_discard() and lo_req_flush()
  block: loop: say goodby to bio
  block: loop: improve performance via blk-mq

1 files changed, 18 insertions, 52 deletions

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4b0d5e71858e..4c35f0822d06 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1585,8 +1585,6 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
         else
                 tag = 0;
 
-        if (test_and_set_bit(tag, &ap->qc_allocated))
-                BUG();
         qc = __ata_qc_from_tag(ap, tag);
 
         qc->tag = tag;
@@ -4722,69 +4720,36 @@ void swap_buf_le16(u16 *buf, unsigned int buf_words)
 }
 
 /**
- *      ata_qc_new - Request an available ATA command, for queueing
- *      @ap: target port
- *
- *      Some ATA host controllers may implement a queue depth which is less
- *      than ATA_MAX_QUEUE. So we shouldn't allocate a tag which is beyond
- *      the hardware limitation.
+ *      ata_qc_new_init - Request an available ATA command, and initialize it
+ *      @dev: Device from whom we request an available command structure
  *
  *      LOCKING:
  *      None.
  */
 
-static struct ata_queued_cmd *ata_qc_new(struct ata_port *ap)
+struct ata_queued_cmd *ata_qc_new_init(struct ata_device *dev, int tag)
 {
-        struct ata_queued_cmd *qc = NULL;
-        unsigned int max_queue = ap->host->n_tags;
-        unsigned int i, tag;
+        struct ata_port *ap = dev->link->ap;
+        struct ata_queued_cmd *qc;
 
         /* no command while frozen */
         if (unlikely(ap->pflags & ATA_PFLAG_FROZEN))
                 return NULL;
 
-        for (i = 0, tag = ap->last_tag + 1; i < max_queue; i++, tag++) {
-                if (ap->flags & ATA_FLAG_LOWTAG)
-                        tag = i;
-                else
-                        tag = tag < max_queue ? tag : 0;
-
-                /* the last tag is reserved for internal command. */
-                if (tag == ATA_TAG_INTERNAL)
-                        continue;
-
-                if (!test_and_set_bit(tag, &ap->qc_allocated)) {
-                        qc = __ata_qc_from_tag(ap, tag);
-                        qc->tag = tag;
-                        ap->last_tag = tag;
-                        break;
-                }
+        /* libsas case */
+        if (!ap->scsi_host) {
+                tag = ata_sas_allocate_tag(ap);
+                if (tag < 0)
+                        return NULL;
         }
 
-        return qc;
-}
-
-/**
- *      ata_qc_new_init - Request an available ATA command, and initialize it
- *      @dev: Device from whom we request an available command structure
- *
- *      LOCKING:
- *      None.
- */
-
-struct ata_queued_cmd *ata_qc_new_init(struct ata_device *dev)
-{
-        struct ata_port *ap = dev->link->ap;
-        struct ata_queued_cmd *qc;
-
-        qc = ata_qc_new(ap);
-        if (qc) {
-                qc->scsicmd = NULL;
-                qc->ap = ap;
-                qc->dev = dev;
+        qc = __ata_qc_from_tag(ap, tag);
+        qc->tag = tag;
+        qc->scsicmd = NULL;
+        qc->ap = ap;
+        qc->dev = dev;
 
-                ata_qc_reinit(qc);
-        }
+        ata_qc_reinit(qc);
 
         return qc;
 }
@@ -4811,7 +4776,8 @@ void ata_qc_free(struct ata_queued_cmd *qc)
         tag = qc->tag;
         if (likely(ata_tag_valid(tag))) {
                 qc->tag = ATA_TAG_POISON;
-                clear_bit(tag, &ap->qc_allocated);
+                if (!ap->scsi_host)
+                        ata_sas_free_tag(tag, ap);
         }
 }