diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/ata_piix.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/ata_piix.c')
-rw-r--r-- | drivers/ata/ata_piix.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index 9842faac097f..43107e9415da 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c | |||
@@ -1562,7 +1562,6 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev) | |||
1562 | static int __devinit piix_init_one(struct pci_dev *pdev, | 1562 | static int __devinit piix_init_one(struct pci_dev *pdev, |
1563 | const struct pci_device_id *ent) | 1563 | const struct pci_device_id *ent) |
1564 | { | 1564 | { |
1565 | static int printed_version; | ||
1566 | struct device *dev = &pdev->dev; | 1565 | struct device *dev = &pdev->dev; |
1567 | struct ata_port_info port_info[2]; | 1566 | struct ata_port_info port_info[2]; |
1568 | const struct ata_port_info *ppi[] = { &port_info[0], &port_info[1] }; | 1567 | const struct ata_port_info *ppi[] = { &port_info[0], &port_info[1] }; |
@@ -1572,9 +1571,7 @@ static int __devinit piix_init_one(struct pci_dev *pdev, | |||
1572 | struct piix_host_priv *hpriv; | 1571 | struct piix_host_priv *hpriv; |
1573 | int rc; | 1572 | int rc; |
1574 | 1573 | ||
1575 | if (!printed_version++) | 1574 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
1576 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
1577 | "version " DRV_VERSION "\n"); | ||
1578 | 1575 | ||
1579 | /* no hotplugging support for later devices (FIXME) */ | 1576 | /* no hotplugging support for later devices (FIXME) */ |
1580 | if (!in_module_init && ent->driver_data >= ich5_sata) | 1577 | if (!in_module_init && ent->driver_data >= ich5_sata) |