aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/acpi
diff options
context:
space:
mode:
authorJiang Liu <liuj97@gmail.com>2013-01-18 11:07:42 -0500
committerBjorn Helgaas <bhelgaas@google.com>2013-02-15 13:35:05 -0500
commitab1a2e038ff2336502e95ec6492c0364a9fc70d0 (patch)
treef69e59b53ed0b01eb4bc04c78ca5e38d2d5919ac /drivers/acpi
parenta2766602ac6885f9514abd97821984cd152cdad3 (diff)
ACPI / PCI: Make pci_slot built-in only, not a module
As discussed in thread at https://patchwork.kernel.org/patch/1946851/, there's no value in supporting CONFIG_ACPI_PCI_SLOT=m any more. So change Kconfig and code to only support building pci_slot as built-in driver. Signed-off-by: Jiang Liu <jiang.liu@huawei.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r--drivers/acpi/Kconfig5
-rw-r--r--drivers/acpi/internal.h5
-rw-r--r--drivers/acpi/pci_slot.c13
-rw-r--r--drivers/acpi/scan.c1
4 files changed, 8 insertions, 16 deletions
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 38c5078da11d..27fde5e8d31a 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -308,7 +308,7 @@ config ACPI_DEBUG_FUNC_TRACE
308 is about half of the penalty and is rarely useful. 308 is about half of the penalty and is rarely useful.
309 309
310config ACPI_PCI_SLOT 310config ACPI_PCI_SLOT
311 tristate "PCI slot detection driver" 311 bool "PCI slot detection driver"
312 depends on SYSFS 312 depends on SYSFS
313 default n 313 default n
314 help 314 help
@@ -317,9 +317,6 @@ config ACPI_PCI_SLOT
317 i.e., segment/bus/device/function tuples, with physical slots in 317 i.e., segment/bus/device/function tuples, with physical slots in
318 the system. If you are unsure, say N. 318 the system. If you are unsure, say N.
319 319
320 To compile this driver as a module, choose M here:
321 the module will be called pci_slot.
322
323config X86_PM_TIMER 320config X86_PM_TIMER
324 bool "Power Management Timer Support" if EXPERT 321 bool "Power Management Timer Support" if EXPERT
325 depends on X86 322 depends on X86
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index e050254ae143..7374cfc5917a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -67,6 +67,11 @@ struct acpi_ec {
67 67
68extern struct acpi_ec *first_ec; 68extern struct acpi_ec *first_ec;
69 69
70#ifdef CONFIG_ACPI_PCI_SLOT
71void acpi_pci_slot_init(void);
72#else
73static inline void acpi_pci_slot_init(void) { }
74#endif
70int acpi_pci_root_init(void); 75int acpi_pci_root_init(void);
71int acpi_ec_init(void); 76int acpi_ec_init(void);
72int acpi_ec_ecdt_probe(void); 77int acpi_ec_ecdt_probe(void);
diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index d22585f21aeb..a7d7e7710f9e 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -330,19 +330,8 @@ static struct dmi_system_id acpi_pci_slot_dmi_table[] __initdata = {
330 {} 330 {}
331}; 331};
332 332
333static int __init 333void __init acpi_pci_slot_init(void)
334acpi_pci_slot_init(void)
335{ 334{
336 dmi_check_system(acpi_pci_slot_dmi_table); 335 dmi_check_system(acpi_pci_slot_dmi_table);
337 acpi_pci_register_driver(&acpi_pci_slot_driver); 336 acpi_pci_register_driver(&acpi_pci_slot_driver);
338 return 0;
339} 337}
340
341static void __exit
342acpi_pci_slot_exit(void)
343{
344 acpi_pci_unregister_driver(&acpi_pci_slot_driver);
345}
346
347module_init(acpi_pci_slot_init);
348module_exit(acpi_pci_slot_exit);
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 7c43bdc36abc..236e476b09c9 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1687,6 +1687,7 @@ int __init acpi_scan_init(void)
1687 1687
1688 acpi_power_init(); 1688 acpi_power_init();
1689 acpi_pci_root_init(); 1689 acpi_pci_root_init();
1690 acpi_pci_slot_init();
1690 1691
1691 /* 1692 /*
1692 * Enumerate devices in the ACPI namespace. 1693 * Enumerate devices in the ACPI namespace.