diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2011-01-06 17:40:00 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2011-01-12 05:05:50 -0500 |
commit | 86e4e20e8a5301ff7104a4f40f35fd5bee408186 (patch) | |
tree | 76c00623e695e1ebe65620b1c0b56c86a18609fe /drivers/acpi | |
parent | d0515d9fec68bace144fda57a69f4268fb875209 (diff) |
ACPI: Always check if _PRW is present before trying to evaluate it
Before evaluating _PRW for devices that are reported as inactive or
not present by their _STA control methods we should check if those
methods are actually present (otherwise the evaulation of _PRW will
obviously fail and a scary message will be printed unnecessarily).
Reported-by: Andreas Mohr <andi@lisas.de>
Reported-by: Maciej Rutecki <maciej.rutecki@gmail.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r-- | drivers/acpi/scan.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 64d4da0d6d52..b5e4dedb497d 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c | |||
@@ -1388,7 +1388,6 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, u32 lvl, | |||
1388 | struct acpi_bus_ops *ops = context; | 1388 | struct acpi_bus_ops *ops = context; |
1389 | int type; | 1389 | int type; |
1390 | unsigned long long sta; | 1390 | unsigned long long sta; |
1391 | struct acpi_device_wakeup wakeup; | ||
1392 | struct acpi_device *device; | 1391 | struct acpi_device *device; |
1393 | acpi_status status; | 1392 | acpi_status status; |
1394 | int result; | 1393 | int result; |
@@ -1399,7 +1398,13 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, u32 lvl, | |||
1399 | 1398 | ||
1400 | if (!(sta & ACPI_STA_DEVICE_PRESENT) && | 1399 | if (!(sta & ACPI_STA_DEVICE_PRESENT) && |
1401 | !(sta & ACPI_STA_DEVICE_FUNCTIONING)) { | 1400 | !(sta & ACPI_STA_DEVICE_FUNCTIONING)) { |
1402 | acpi_bus_extract_wakeup_device_power_package(handle, &wakeup); | 1401 | struct acpi_device_wakeup wakeup; |
1402 | acpi_handle temp; | ||
1403 | |||
1404 | status = acpi_get_handle(handle, "_PRW", &temp); | ||
1405 | if (ACPI_SUCCESS(status)) | ||
1406 | acpi_bus_extract_wakeup_device_power_package(handle, | ||
1407 | &wakeup); | ||
1403 | return AE_CTRL_DEPTH; | 1408 | return AE_CTRL_DEPTH; |
1404 | } | 1409 | } |
1405 | 1410 | ||