diff options
author | Julia Lawall <julia@diku.dk> | 2008-04-10 22:09:24 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2008-04-29 02:52:45 -0400 |
commit | 9030062f3d61f87c1e787b3aa134fa3a8e4b2d25 (patch) | |
tree | a24cd60df75180ac54a115842be631bd3f3ed003 /drivers/acpi/video.c | |
parent | e9ae71078b2c8657c0e8de808b76b76049806906 (diff) |
ACPI: elide a non-zero test on a result that is never 0
thermal_cooling_device_register used to return NULL if THERMAL is "n".
As the ACPI fan, processor and video drivers SELECT the generic
thermal in PATCH 01, this is not a problem any more.
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/video.c')
-rw-r--r-- | drivers/acpi/video.c | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 980a74188781..55c095619379 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c | |||
@@ -734,21 +734,19 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) | |||
734 | if (IS_ERR(device->cdev)) | 734 | if (IS_ERR(device->cdev)) |
735 | return; | 735 | return; |
736 | 736 | ||
737 | if (device->cdev) { | 737 | printk(KERN_INFO PREFIX |
738 | printk(KERN_INFO PREFIX | 738 | "%s is registered as cooling_device%d\n", |
739 | "%s is registered as cooling_device%d\n", | 739 | device->dev->dev.bus_id, device->cdev->id); |
740 | device->dev->dev.bus_id, device->cdev->id); | 740 | result = sysfs_create_link(&device->dev->dev.kobj, |
741 | result = sysfs_create_link(&device->dev->dev.kobj, | 741 | &device->cdev->device.kobj, |
742 | &device->cdev->device.kobj, | 742 | "thermal_cooling"); |
743 | "thermal_cooling"); | 743 | if (result) |
744 | if (result) | 744 | printk(KERN_ERR PREFIX "Create sysfs link\n"); |
745 | printk(KERN_ERR PREFIX "Create sysfs link\n"); | 745 | result = sysfs_create_link(&device->cdev->device.kobj, |
746 | result = sysfs_create_link(&device->cdev->device.kobj, | 746 | &device->dev->dev.kobj, "device"); |
747 | &device->dev->dev.kobj, | 747 | if (result) |
748 | "device"); | 748 | printk(KERN_ERR PREFIX "Create sysfs link\n"); |
749 | if (result) | 749 | |
750 | printk(KERN_ERR PREFIX "Create sysfs link\n"); | ||
751 | } | ||
752 | } | 750 | } |
753 | if (device->cap._DCS && device->cap._DSS){ | 751 | if (device->cap._DCS && device->cap._DSS){ |
754 | static int count = 0; | 752 | static int count = 0; |