ACPICA 20050708 from Bob Moore <robert.moore@intel.com>

The use of the CPU stack in the debug version of the
subsystem has been considerably reduced.  Previously, a
debug structure was declared in every function that used
the debug macros.  This structure has been removed in
favor of declaring the individual elements as parameters
to the debug functions.  This reduces the cumulative stack
use during nested execution of ACPI function calls at the
cost of a small increase in the code size of the debug
version of the subsystem.  With assistance from Alexey
Starikovskiy and Len Brown.

Added the ACPI_GET_FUNCTION_NAME macro to enable the
compiler-dependent headers to define a macro that will
return the current function name at runtime (such as
__FUNCTION__ or _func_, etc.) The function name is used
by the debug trace output.  If ACPI_GET_FUNCTION_NAME
is not defined in the compiler-dependent header, the
function name is saved on the CPU stack (one pointer per
function.) This mechanism is used because apparently there
exists no standard ANSI-C defined macro that that returns
the function name.

Alexey Starikovskiy redesigned and reimplemented the
"Owner ID" mechanism used to track namespace objects
created/deleted by ACPI tables and control method
execution.  A bitmap is now used to allocate and free the
IDs, thus solving the wraparound problem present in the
previous implementation.  The size of the namespace node
descriptor was reduced by 2 bytes as a result.

Removed the UINT32_BIT and UINT16_BIT types that were used
for the bitfield flag definitions within the headers for
the predefined ACPI tables.  These have been replaced by
UINT8_BIT in order to increase the code portability of
the subsystem.  If the use of UINT8 remains a problem,
we may be forced to eliminate bitfields entirely because
of a lack of portability.

Alexey Starikovksiy enhanced the performance of
acpi_ut_update_object_reference.  This is a frequently used
function and this improvement increases the performance
of the entire subsystem.

Alexey Starikovskiy fixed several possible memory leaks
and the inverse - premature object deletion.

Signed-off-by: Len Brown <len.brown@intel.com>

1 files changed, 31 insertions, 67 deletions

diff --git a/drivers/acpi/utilities/utdelete.c b/drivers/acpi/utilities/utdelete.c
index be97ada23c3d..eeafb324c504 100644
--- a/drivers/acpi/utilities/utdelete.c
+++ b/drivers/acpi/utilities/utdelete.c
@@ -435,35 +435,24 @@ acpi_ut_update_object_reference (
         union acpi_operand_object       *object,
         u16                             action)
 {
-        acpi_status                     status;
-        u32                             i;
-        union acpi_generic_state         *state_list = NULL;
-        union acpi_generic_state         *state;
+        acpi_status                     status = AE_OK;
+        union acpi_generic_state        *state_list = NULL;
+        union acpi_operand_object       *next_object = NULL;
+        union acpi_generic_state        *state;
+        acpi_native_uint                i;
 
 
         ACPI_FUNCTION_TRACE_PTR ("ut_update_object_reference", object);
 
 
-        /* Ignore a null object ptr */
+        while (object) {
+                /* Make sure that this isn't a namespace handle */
 
-        if (!object) {
-                return_ACPI_STATUS (AE_OK);
-        }
-
-        /* Make sure that this isn't a namespace handle */
-
-        if (ACPI_GET_DESCRIPTOR_TYPE (object) == ACPI_DESC_TYPE_NAMED) {
-                ACPI_DEBUG_PRINT ((ACPI_DB_ALLOCATIONS,
-                        "Object %p is NS handle\n", object));
-                return_ACPI_STATUS (AE_OK);
-        }
-
-        state = acpi_ut_create_update_state (object, action);
-
-        while (state) {
-                object = state->update.object;
-                action = state->update.value;
-                acpi_ut_delete_generic_state (state);
+                if (ACPI_GET_DESCRIPTOR_TYPE (object) == ACPI_DESC_TYPE_NAMED) {
+                        ACPI_DEBUG_PRINT ((ACPI_DB_ALLOCATIONS,
+                                "Object %p is NS handle\n", object));
+                        return_ACPI_STATUS (AE_OK);
+                }
 
                 /*
                  * All sub-objects must have their reference count incremented also.
@@ -476,12 +465,10 @@ acpi_ut_update_object_reference (
                         acpi_ut_update_ref_count (object->device.device_notify, action);
                         break;
 
-
                 case ACPI_TYPE_PACKAGE:
-
                         /*
-                         * We must update all the sub-objects of the package
-                         * (Each of whom may have their own sub-objects, etc.
+                         * We must update all the sub-objects of the package,
+                         * each of whom may have their own sub-objects.
                          */
                         for (i = 0; i < object->package.count; i++) {
                                 /*
@@ -497,35 +484,19 @@ acpi_ut_update_object_reference (
                         }
                         break;
 
-
                 case ACPI_TYPE_BUFFER_FIELD:
 
-                        status = acpi_ut_create_update_state_and_push (
-                                         object->buffer_field.buffer_obj, action, &state_list);
-                        if (ACPI_FAILURE (status)) {
-                                goto error_exit;
-                        }
+                        next_object = object->buffer_field.buffer_obj;
                         break;
 
-
                 case ACPI_TYPE_LOCAL_REGION_FIELD:
 
-                        status = acpi_ut_create_update_state_and_push (
-                                         object->field.region_obj, action, &state_list);
-                        if (ACPI_FAILURE (status)) {
-                                goto error_exit;
-                        }
-                   break;
-
+                        next_object = object->field.region_obj;
+                        break;
 
                 case ACPI_TYPE_LOCAL_BANK_FIELD:
 
-                        status = acpi_ut_create_update_state_and_push (
-                                         object->bank_field.bank_obj, action, &state_list);
-                        if (ACPI_FAILURE (status)) {
-                                goto error_exit;
-                        }
-
+                        next_object = object->bank_field.bank_obj;
                         status = acpi_ut_create_update_state_and_push (
                                          object->bank_field.region_obj, action, &state_list);
                         if (ACPI_FAILURE (status)) {
@@ -533,15 +504,9 @@ acpi_ut_update_object_reference (
                         }
                         break;
 
-
                 case ACPI_TYPE_LOCAL_INDEX_FIELD:
 
-                        status = acpi_ut_create_update_state_and_push (
-                                         object->index_field.index_obj, action, &state_list);
-                        if (ACPI_FAILURE (status)) {
-                                goto error_exit;
-                        }
-
+                        next_object = object->index_field.index_obj;
                         status = acpi_ut_create_update_state_and_push (
                                          object->index_field.data_obj, action, &state_list);
                         if (ACPI_FAILURE (status)) {
@@ -549,28 +514,19 @@ acpi_ut_update_object_reference (
                         }
                         break;
 
-
                 case ACPI_TYPE_LOCAL_REFERENCE:
-
                         /*
                          * The target of an Index (a package, string, or buffer) must track
                          * changes to the ref count of the index.
                          */
                         if (object->reference.opcode == AML_INDEX_OP) {
-                                status = acpi_ut_create_update_state_and_push (
-                                                 object->reference.object, action, &state_list);
-                                if (ACPI_FAILURE (status)) {
-                                        goto error_exit;
-                                }
+                                next_object = object->reference.object;
                         }
                         break;
 
-
                 case ACPI_TYPE_REGION:
                 default:
-
-                        /* No subobjects */
-                        break;
+                        break;/* No subobjects */
                 }
 
                 /*
@@ -579,15 +535,23 @@ acpi_ut_update_object_reference (
                  * main object to be deleted.
                  */
                 acpi_ut_update_ref_count (object, action);
+                object = NULL;
 
                 /* Move on to the next object to be updated */
 
-                state = acpi_ut_pop_generic_state (&state_list);
+                if (next_object) {
+                        object = next_object;
+                        next_object = NULL;
+                }
+                else if (state_list) {
+                        state = acpi_ut_pop_generic_state (&state_list);
+                        object = state->update.object;
+                        acpi_ut_delete_generic_state (state);
+                }
         }
 
         return_ACPI_STATUS (AE_OK);
 
-
 error_exit:
 
         ACPI_REPORT_ERROR (("Could not update object reference count, %s\n",