[ACPI] ACPICA 20060210

Removed a couple of extraneous ACPI_ERROR messages that
appeared during normal execution. These became apparent
after the conversion from ACPI_DEBUG_PRINT.

Fixed a problem where the CreateField operator could hang
if the BitIndex or NumBits parameter referred to a named
object. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5359

Fixed a problem where a DeRefOf operation on a buffer
object incorrectly failed with an exception. This also
fixes a couple of related RefOf and DeRefOf issues.
From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5360
http://bugzilla.kernel.org/show_bug.cgi?id=5387
http://bugzilla.kernel.org/show_bug.cgi?id=5392

Fixed a problem where the AE_BUFFER_LIMIT exception was
returned instead of AE_STRING_LIMIT on an out-of-bounds
Index() operation. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5480

Implemented a memory cleanup at the end of the execution
of each iteration of an AML While() loop, preventing the
accumulation of outstanding objects. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5427

Eliminated a chunk of duplicate code in the object
resolution code. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5336

Fixed several warnings during the 64-bit code generation.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

8 files changed, 31 insertions, 0 deletions

diff --git a/drivers/acpi/tables/tbconvrt.c b/drivers/acpi/tables/tbconvrt.c
index 03b37d2223bc..254ebdbb7bef 100644
--- a/drivers/acpi/tables/tbconvrt.c
+++ b/drivers/acpi/tables/tbconvrt.c
@@ -147,6 +147,7 @@ acpi_status acpi_tb_convert_to_xsdt(struct acpi_table_desc *table_info)
         /* Copy the table pointers */
 
         for (i = 0; i < acpi_gbl_rsdt_table_count; i++) {
+
                 /* RSDT pointers are 32 bits, XSDT pointers are 64 bits */
 
                 if (acpi_gbl_root_table_type == ACPI_TABLE_TYPE_RSDT) {
@@ -515,6 +516,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
 
         if (acpi_gbl_FADT->revision >= FADT2_REVISION_ID) {
                 if (acpi_gbl_FADT->length < sizeof(struct fadt_descriptor_rev2)) {
+
                         /* Length is too short to be a V2.0 table */
 
                         ACPI_WARNING((AE_INFO,
@@ -603,6 +605,7 @@ acpi_status acpi_tb_build_common_facs(struct acpi_table_desc *table_info)
         if ((acpi_gbl_RSDP->revision < 2) ||
             (acpi_gbl_FACS->length < 32) ||
             (!(acpi_gbl_FACS->xfirmware_waking_vector))) {
+
                 /* ACPI 1.0 FACS or short table or optional X_ field is zero */
 
                 acpi_gbl_common_fACS.firmware_waking_vector = ACPI_CAST_PTR(u64,
diff --git a/drivers/acpi/tables/tbget.c b/drivers/acpi/tables/tbget.c
index 09b4ee6dfd60..4615e1afe8de 100644
--- a/drivers/acpi/tables/tbget.c
+++ b/drivers/acpi/tables/tbget.c
@@ -148,6 +148,10 @@ acpi_tb_get_table_header(struct acpi_pointer *address,
                                             sizeof(struct acpi_table_header),
                                             (void *)&header);
                 if (ACPI_FAILURE(status)) {
+                        ACPI_ERROR((AE_INFO,
+                                    "Could not map memory at %8.8X%8.8X for table header",
+                                    ACPI_FORMAT_UINT64(address->pointer.
+                                                       physical)));
                         return_ACPI_STATUS(status);
                 }
 
@@ -208,6 +212,7 @@ acpi_tb_get_table_body(struct acpi_pointer *address,
 
         status = acpi_tb_table_override(header, table_info);
         if (ACPI_SUCCESS(status)) {
+
                 /* Table was overridden by the host OS */
 
                 return_ACPI_STATUS(status);
@@ -250,6 +255,7 @@ acpi_tb_table_override(struct acpi_table_header *header,
          */
         status = acpi_os_table_override(header, &new_table);
         if (ACPI_FAILURE(status)) {
+
                 /* Some severe error from the OSL, but we basically ignore it */
 
                 ACPI_EXCEPTION((AE_INFO, status,
@@ -258,6 +264,7 @@ acpi_tb_table_override(struct acpi_table_header *header,
         }
 
         if (!new_table) {
+
                 /* No table override */
 
                 return_ACPI_STATUS(AE_NO_ACPI_TABLES);
@@ -381,6 +388,7 @@ acpi_tb_get_this_table(struct acpi_pointer *address,
 
 #if (!ACPI_CHECKSUM_ABORT)
                 if (ACPI_FAILURE(status)) {
+
                         /* Ignore the error if configuration says so */
 
                         status = AE_OK;
@@ -440,6 +448,7 @@ acpi_tb_get_table_ptr(acpi_table_type table_type,
          * instance is always in the list head.
          */
         if (instance == 1) {
+
                 /* Get the first */
 
                 *table_ptr_loc = NULL;
diff --git a/drivers/acpi/tables/tbgetall.c b/drivers/acpi/tables/tbgetall.c
index 134e5dce0bc1..b4ec61d7cf06 100644
--- a/drivers/acpi/tables/tbgetall.c
+++ b/drivers/acpi/tables/tbgetall.c
@@ -223,6 +223,7 @@ acpi_status acpi_tb_get_required_tables(void)
          * any SSDTs.
          */
         for (i = 0; i < acpi_gbl_rsdt_table_count; i++) {
+
                 /* Get the table address from the common internal XSDT */
 
                 address.pointer.value = acpi_gbl_XSDT->table_offset_entry[i];
diff --git a/drivers/acpi/tables/tbinstal.c b/drivers/acpi/tables/tbinstal.c
index 7ffd0fddb4e5..ec2cb978b7c4 100644
--- a/drivers/acpi/tables/tbinstal.c
+++ b/drivers/acpi/tables/tbinstal.c
@@ -84,6 +84,7 @@ acpi_tb_match_signature(char *signature,
 
                 if (!ACPI_STRNCMP(signature, acpi_gbl_table_data[i].signature,
                                   acpi_gbl_table_data[i].sig_length)) {
+
                         /* Found a signature match, return index if requested */
 
                         if (table_info) {
diff --git a/drivers/acpi/tables/tbrsdt.c b/drivers/acpi/tables/tbrsdt.c
index 4d308220225d..946d2f2d611d 100644
--- a/drivers/acpi/tables/tbrsdt.c
+++ b/drivers/acpi/tables/tbrsdt.c
@@ -190,6 +190,7 @@ acpi_status acpi_tb_validate_rsdt(struct acpi_table_header *table_ptr)
         }
 
         if (no_match) {
+
                 /* Invalid RSDT or XSDT signature */
 
                 ACPI_ERROR((AE_INFO,
diff --git a/drivers/acpi/tables/tbutils.c b/drivers/acpi/tables/tbutils.c
index bc571592f087..b463d4b88823 100644
--- a/drivers/acpi/tables/tbutils.c
+++ b/drivers/acpi/tables/tbutils.c
@@ -96,6 +96,7 @@ acpi_status acpi_tb_is_table_installed(struct acpi_table_desc *new_table_desc)
                     (!ACPI_MEMCMP
                      (table_desc->pointer, new_table_desc->pointer,
                       new_table_desc->pointer->length))) {
+
                         /* Match: this table is already installed */
 
                         ACPI_DEBUG_PRINT((ACPI_DB_TABLES,
@@ -249,6 +250,7 @@ u8 acpi_tb_generate_checksum(void *buffer, u32 length)
         u8 sum = 0;
 
         if (buffer && length) {
+
                 /*  Buffer and Length are valid   */
 
                 end_buffer = ACPI_ADD_PTR(u8, buffer, length);
diff --git a/drivers/acpi/tables/tbxface.c b/drivers/acpi/tables/tbxface.c
index 9fe53c9d5b9a..3e902cdb83e1 100644
--- a/drivers/acpi/tables/tbxface.c
+++ b/drivers/acpi/tables/tbxface.c
@@ -174,6 +174,7 @@ acpi_status acpi_load_table(struct acpi_table_header *table_ptr)
         status = acpi_tb_install_table(&table_info);
         if (ACPI_FAILURE(status)) {
                 if (status == AE_ALREADY_EXISTS) {
+
                         /* Table already exists, no error */
 
                         status = AE_OK;
@@ -208,6 +209,7 @@ acpi_status acpi_load_table(struct acpi_table_header *table_ptr)
         }
 
         if (ACPI_FAILURE(status)) {
+
                 /* Uninstall table and free the buffer */
 
                 (void)acpi_tb_uninstall_table(table_info.installed_desc);
@@ -397,6 +399,7 @@ acpi_get_table(acpi_table_type table_type,
         /* Get the table length */
 
         if (table_type == ACPI_TABLE_RSDP) {
+
                 /* RSD PTR is the only "table" without a header */
 
                 table_length = sizeof(struct rsdp_descriptor);
diff --git a/drivers/acpi/tables/tbxfroot.c b/drivers/acpi/tables/tbxfroot.c
index a62db6af83c9..7f68b759f15a 100644
--- a/drivers/acpi/tables/tbxfroot.c
+++ b/drivers/acpi/tables/tbxfroot.c
@@ -75,6 +75,7 @@ acpi_status acpi_tb_validate_rsdp(struct rsdp_descriptor *rsdp)
          *  The signature and checksum must both be correct
          */
         if (ACPI_STRNCMP((char *)rsdp, RSDP_SIG, sizeof(RSDP_SIG) - 1) != 0) {
+
                 /* Nope, BAD Signature */
 
                 return (AE_BAD_SIGNATURE);
@@ -217,6 +218,7 @@ acpi_get_firmware_table(acpi_string signature,
         /* Ensure that we have a RSDP */
 
         if (!acpi_gbl_RSDP) {
+
                 /* Get the RSDP */
 
                 status = acpi_os_get_root_pointer(flags, &address);
@@ -327,10 +329,12 @@ acpi_get_firmware_table(acpi_string signature,
                 /* Compare table signatures and table instance */
 
                 if (!ACPI_STRNCMP(header->signature, signature, ACPI_NAME_SIZE)) {
+
                         /* An instance of the table was found */
 
                         j++;
                         if (j >= instance) {
+
                                 /* Found the correct instance, get the entire table */
 
                                 status =
@@ -434,12 +438,14 @@ static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length)
 
         for (mem_rover = start_address; mem_rover < end_address;
              mem_rover += ACPI_RSDP_SCAN_STEP) {
+
                 /* The RSDP signature and checksum must both be correct */
 
                 status =
                     acpi_tb_validate_rsdp(ACPI_CAST_PTR
                                           (struct rsdp_descriptor, mem_rover));
                 if (ACPI_SUCCESS(status)) {
+
                         /* Sig and checksum valid, we have found a real RSDP */
 
                         ACPI_DEBUG_PRINT((ACPI_DB_INFO,
@@ -495,6 +501,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
          * Scan supports either logical addressing or physical addressing
          */
         if ((flags & ACPI_MEMORY_MODE) == ACPI_LOGICAL_ADDRESSING) {
+
                 /* 1a) Get the location of the Extended BIOS Data Area (EBDA) */
 
                 status = acpi_os_map_memory((acpi_physical_address)
@@ -542,6 +549,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
                         acpi_os_unmap_memory(table_ptr, ACPI_EBDA_WINDOW_SIZE);
 
                         if (mem_rover) {
+
                                 /* Return the physical address */
 
                                 physical_address +=
@@ -576,6 +584,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
                 acpi_os_unmap_memory(table_ptr, ACPI_HI_RSDP_WINDOW_SIZE);
 
                 if (mem_rover) {
+
                         /* Return the physical address */
 
                         physical_address =
@@ -609,6 +618,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
                                                          (physical_address),
                                                          ACPI_EBDA_WINDOW_SIZE);
                         if (mem_rover) {
+
                                 /* Return the physical address */
 
                                 table_info->physical_address =
@@ -624,6 +634,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
                                                  (ACPI_HI_RSDP_WINDOW_BASE),
                                                  ACPI_HI_RSDP_WINDOW_SIZE);
                 if (mem_rover) {
+
                         /* Found it, return the physical address */
 
                         table_info->physical_address =