diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2008-01-07 18:05:21 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2008-02-01 18:30:56 -0500 |
commit | c95d47a868f35cd47643d116a3c680cdaa954df8 (patch) | |
tree | 36e3b820c8bb0c1c962029ce5a28c6e3251443a9 /drivers/acpi/sleep | |
parent | c697eecebc6cfc0b393afea3c4ff1a5041526ad1 (diff) |
ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK
The execution of ACPI global control methods _GTS and _BFS is
currently tied to the preparation to enter a sleep state and to the
leaving of the sleep state, respectively. However, these functions
are called before disabling the nonboot CPUs and after enabling
them, respectively (in fact, on ACPI 1.0x systems the first of them
ought to be called before suspending devices), while according to the
ACPI specification, _GTS is to be executed right prior to entering
the system sleep state and _BFS is to be executed right after the
platfor firmware has returned control to the OS on wake up.
Move the execution of _GTS and _BFS to the right places.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/sleep')
-rw-r--r-- | drivers/acpi/sleep/main.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/acpi/sleep/main.c b/drivers/acpi/sleep/main.c index e2e4e617952b..fdd8139b3f98 100644 --- a/drivers/acpi/sleep/main.c +++ b/drivers/acpi/sleep/main.c | |||
@@ -139,6 +139,9 @@ static int acpi_pm_enter(suspend_state_t pm_state) | |||
139 | break; | 139 | break; |
140 | } | 140 | } |
141 | 141 | ||
142 | /* Reprogram control registers and execute _BFS */ | ||
143 | acpi_leave_sleep_state_prep(acpi_state); | ||
144 | |||
142 | /* ACPI 3.0 specs (P62) says that it's the responsabilty | 145 | /* ACPI 3.0 specs (P62) says that it's the responsabilty |
143 | * of the OSPM to clear the status bit [ implying that the | 146 | * of the OSPM to clear the status bit [ implying that the |
144 | * POWER_BUTTON event should not reach userspace ] | 147 | * POWER_BUTTON event should not reach userspace ] |
@@ -272,6 +275,8 @@ static int acpi_hibernation_enter(void) | |||
272 | acpi_enable_wakeup_device(ACPI_STATE_S4); | 275 | acpi_enable_wakeup_device(ACPI_STATE_S4); |
273 | /* This shouldn't return. If it returns, we have a problem */ | 276 | /* This shouldn't return. If it returns, we have a problem */ |
274 | status = acpi_enter_sleep_state(ACPI_STATE_S4); | 277 | status = acpi_enter_sleep_state(ACPI_STATE_S4); |
278 | /* Reprogram control registers and execute _BFS */ | ||
279 | acpi_leave_sleep_state_prep(ACPI_STATE_S4); | ||
275 | local_irq_restore(flags); | 280 | local_irq_restore(flags); |
276 | 281 | ||
277 | return ACPI_SUCCESS(status) ? 0 : -EFAULT; | 282 | return ACPI_SUCCESS(status) ? 0 : -EFAULT; |
@@ -284,6 +289,8 @@ static void acpi_hibernation_leave(void) | |||
284 | * enable it here. | 289 | * enable it here. |
285 | */ | 290 | */ |
286 | acpi_enable(); | 291 | acpi_enable(); |
292 | /* Reprogram control registers and execute _BFS */ | ||
293 | acpi_leave_sleep_state_prep(ACPI_STATE_S4); | ||
287 | } | 294 | } |
288 | 295 | ||
289 | static void acpi_hibernation_finish(void) | 296 | static void acpi_hibernation_finish(void) |