diff options
author | Rui Zhang <rui.zhang@intel.com> | 2006-12-21 02:21:13 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2006-12-21 03:07:37 -0500 |
commit | 2786f6e388e9dfe9e7b1c3c6bd7fcfba9cfb9831 (patch) | |
tree | 76f0bbaf42cc977a3b6944314f4c3043937a8ee7 /drivers/acpi/pci_root.c | |
parent | e49bd2dd5a503bb94fe2f2af45422b610940b75d (diff) |
ACPI: fix Supermicro X7DB8+ Boot regression
http://bugzilla.kernel.org/show_bug.cgi?id=7695
Originally we converted bind/unbind to use a new pci bridge driver.
The driver will add/remove _PRT, so we can eventually remove
.bind/.unbind methods.
But we found that some of the _ADR-Based devices don't have _PRT,
i.e. they are not managed by the new ACPI PCI bridge driver.
So that .bind method is not called for some _ADR-Based devices,
which leads to a failure.
Now we make ACPI PCI Root Bridge Driver scan and binds all _ADR-Based devices
once the driver is loaded, in the .add method of ACPI PCI Root Bridge driver.
Extra code path for calling .bind/.unbind when _ADR-Based devices
are hot added/removed is also added.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/pci_root.c')
-rw-r--r-- | drivers/acpi/pci_root.c | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c index 9cfc74192419..2e1a74a967bb 100644 --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c | |||
@@ -151,6 +151,21 @@ static acpi_status try_get_root_bridge_busnr(acpi_handle handle, int *busnum) | |||
151 | return AE_OK; | 151 | return AE_OK; |
152 | } | 152 | } |
153 | 153 | ||
154 | static void acpi_pci_bridge_scan(struct acpi_device *device) | ||
155 | { | ||
156 | int status; | ||
157 | struct acpi_device *child = NULL; | ||
158 | |||
159 | if (device->flags.bus_address) | ||
160 | if (device->parent && device->parent->ops.bind) { | ||
161 | status = device->parent->ops.bind(device); | ||
162 | if (!status) { | ||
163 | list_for_each_entry(child, &device->children, node) | ||
164 | acpi_pci_bridge_scan(child); | ||
165 | } | ||
166 | } | ||
167 | } | ||
168 | |||
154 | static int acpi_pci_root_add(struct acpi_device *device) | 169 | static int acpi_pci_root_add(struct acpi_device *device) |
155 | { | 170 | { |
156 | int result = 0; | 171 | int result = 0; |
@@ -159,6 +174,7 @@ static int acpi_pci_root_add(struct acpi_device *device) | |||
159 | acpi_status status = AE_OK; | 174 | acpi_status status = AE_OK; |
160 | unsigned long value = 0; | 175 | unsigned long value = 0; |
161 | acpi_handle handle = NULL; | 176 | acpi_handle handle = NULL; |
177 | struct acpi_device *child; | ||
162 | 178 | ||
163 | 179 | ||
164 | if (!device) | 180 | if (!device) |
@@ -175,6 +191,8 @@ static int acpi_pci_root_add(struct acpi_device *device) | |||
175 | strcpy(acpi_device_class(device), ACPI_PCI_ROOT_CLASS); | 191 | strcpy(acpi_device_class(device), ACPI_PCI_ROOT_CLASS); |
176 | acpi_driver_data(device) = root; | 192 | acpi_driver_data(device) = root; |
177 | 193 | ||
194 | device->ops.bind = acpi_pci_bind; | ||
195 | |||
178 | /* | 196 | /* |
179 | * Segment | 197 | * Segment |
180 | * ------- | 198 | * ------- |
@@ -294,6 +312,12 @@ static int acpi_pci_root_add(struct acpi_device *device) | |||
294 | result = acpi_pci_irq_add_prt(device->handle, root->id.segment, | 312 | result = acpi_pci_irq_add_prt(device->handle, root->id.segment, |
295 | root->id.bus); | 313 | root->id.bus); |
296 | 314 | ||
315 | /* | ||
316 | * Scan and bind all _ADR-Based Devices | ||
317 | */ | ||
318 | list_for_each_entry(child, &device->children, node) | ||
319 | acpi_pci_bridge_scan(child); | ||
320 | |||
297 | end: | 321 | end: |
298 | if (result) { | 322 | if (result) { |
299 | if (!list_empty(&root->node)) | 323 | if (!list_empty(&root->node)) |