diff options
author | Len Brown <len.brown@intel.com> | 2006-07-10 01:35:51 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2006-07-10 02:37:22 -0400 |
commit | e21c1ca3f98529921c829a792dfdbfc5a5dc393b (patch) | |
tree | fdb0a3c00d46db197ae65e6c66fc841b194cb507 /drivers/acpi/pci_link.c | |
parent | b3cf257623fabd8f1ee6700a6d328cc1c5da5a1d (diff) |
ACPI: acpi_os_allocate() fixes
Replace acpi_in_resume with a more general hack
to check irqs_disabled() on any kmalloc() from ACPI.
While setting (system_state != SYSTEM_RUNNING) on resume
seemed more general, Andrew Morton preferred this approach.
http://bugzilla.kernel.org/show_bug.cgi?id=3469
Make acpi_os_allocate() into an inline function to
allow /proc/slab_allocators to work.
Delete some memset() that could fault on allocation failure.
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/pci_link.c')
-rw-r--r-- | drivers/acpi/pci_link.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index 8197c0e40769..7f3e7e77e794 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c | |||
@@ -780,11 +780,6 @@ static int acpi_pci_link_resume(struct acpi_pci_link *link) | |||
780 | return 0; | 780 | return 0; |
781 | } | 781 | } |
782 | 782 | ||
783 | /* | ||
784 | * FIXME: this is a workaround to avoid nasty warning. It will be removed | ||
785 | * after every device calls pci_disable_device in .resume. | ||
786 | */ | ||
787 | int acpi_in_resume; | ||
788 | static int irqrouter_resume(struct sys_device *dev) | 783 | static int irqrouter_resume(struct sys_device *dev) |
789 | { | 784 | { |
790 | struct list_head *node = NULL; | 785 | struct list_head *node = NULL; |
@@ -794,7 +789,6 @@ static int irqrouter_resume(struct sys_device *dev) | |||
794 | /* Make sure SCI is enabled again (Apple firmware bug?) */ | 789 | /* Make sure SCI is enabled again (Apple firmware bug?) */ |
795 | acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1, ACPI_MTX_DO_NOT_LOCK); | 790 | acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1, ACPI_MTX_DO_NOT_LOCK); |
796 | 791 | ||
797 | acpi_in_resume = 1; | ||
798 | list_for_each(node, &acpi_link.entries) { | 792 | list_for_each(node, &acpi_link.entries) { |
799 | link = list_entry(node, struct acpi_pci_link, node); | 793 | link = list_entry(node, struct acpi_pci_link, node); |
800 | if (!link) { | 794 | if (!link) { |
@@ -803,7 +797,6 @@ static int irqrouter_resume(struct sys_device *dev) | |||
803 | } | 797 | } |
804 | acpi_pci_link_resume(link); | 798 | acpi_pci_link_resume(link); |
805 | } | 799 | } |
806 | acpi_in_resume = 0; | ||
807 | return 0; | 800 | return 0; |
808 | } | 801 | } |
809 | 802 | ||