diff options
author | Robert Moore <robert.moore@intel.com> | 2005-07-08 00:00:00 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2005-07-14 00:42:23 -0400 |
commit | f9f4601f331aa1226d7a798a01950efbb388f07f (patch) | |
tree | 62e079a9275749d16a4a0da56a427be201e15d27 /drivers/acpi/parser | |
parent | 4c3ffbd79529b680b3c3ef2b6f42f0c89c694ec5 (diff) |
ACPICA 20050708 from Bob Moore <robert.moore@intel.com>
The use of the CPU stack in the debug version of the
subsystem has been considerably reduced. Previously, a
debug structure was declared in every function that used
the debug macros. This structure has been removed in
favor of declaring the individual elements as parameters
to the debug functions. This reduces the cumulative stack
use during nested execution of ACPI function calls at the
cost of a small increase in the code size of the debug
version of the subsystem. With assistance from Alexey
Starikovskiy and Len Brown.
Added the ACPI_GET_FUNCTION_NAME macro to enable the
compiler-dependent headers to define a macro that will
return the current function name at runtime (such as
__FUNCTION__ or _func_, etc.) The function name is used
by the debug trace output. If ACPI_GET_FUNCTION_NAME
is not defined in the compiler-dependent header, the
function name is saved on the CPU stack (one pointer per
function.) This mechanism is used because apparently there
exists no standard ANSI-C defined macro that that returns
the function name.
Alexey Starikovskiy redesigned and reimplemented the
"Owner ID" mechanism used to track namespace objects
created/deleted by ACPI tables and control method
execution. A bitmap is now used to allocate and free the
IDs, thus solving the wraparound problem present in the
previous implementation. The size of the namespace node
descriptor was reduced by 2 bytes as a result.
Removed the UINT32_BIT and UINT16_BIT types that were used
for the bitfield flag definitions within the headers for
the predefined ACPI tables. These have been replaced by
UINT8_BIT in order to increase the code portability of
the subsystem. If the use of UINT8 remains a problem,
we may be forced to eliminate bitfields entirely because
of a lack of portability.
Alexey Starikovksiy enhanced the performance of
acpi_ut_update_object_reference. This is a frequently used
function and this improvement increases the performance
of the entire subsystem.
Alexey Starikovskiy fixed several possible memory leaks
and the inverse - premature object deletion.
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/parser')
-rw-r--r-- | drivers/acpi/parser/psloop.c | 9 | ||||
-rw-r--r-- | drivers/acpi/parser/psxface.c | 7 |
2 files changed, 12 insertions, 4 deletions
diff --git a/drivers/acpi/parser/psloop.c b/drivers/acpi/parser/psloop.c index decb2e9a049d..095672a1a722 100644 --- a/drivers/acpi/parser/psloop.c +++ b/drivers/acpi/parser/psloop.c | |||
@@ -407,9 +407,14 @@ acpi_ps_parse_loop ( | |||
407 | INCREMENT_ARG_LIST (walk_state->arg_types); | 407 | INCREMENT_ARG_LIST (walk_state->arg_types); |
408 | } | 408 | } |
409 | 409 | ||
410 | |||
410 | /* Special processing for certain opcodes */ | 411 | /* Special processing for certain opcodes */ |
411 | 412 | ||
412 | if ((walk_state->pass_number <= ACPI_IMODE_LOAD_PASS1) && | 413 | /* TBD (remove): Temporary mechanism to disable this code if needed */ |
414 | |||
415 | #ifndef ACPI_NO_MODULE_LEVEL_CODE | ||
416 | |||
417 | if ((walk_state->pass_number <= ACPI_IMODE_LOAD_PASS1) && | ||
413 | ((walk_state->parse_flags & ACPI_PARSE_DISASSEMBLE) == 0)) { | 418 | ((walk_state->parse_flags & ACPI_PARSE_DISASSEMBLE) == 0)) { |
414 | /* | 419 | /* |
415 | * We want to skip If/Else/While constructs during Pass1 | 420 | * We want to skip If/Else/While constructs during Pass1 |
@@ -434,7 +439,7 @@ acpi_ps_parse_loop ( | |||
434 | break; | 439 | break; |
435 | } | 440 | } |
436 | } | 441 | } |
437 | 442 | #endif | |
438 | switch (op->common.aml_opcode) { | 443 | switch (op->common.aml_opcode) { |
439 | case AML_METHOD_OP: | 444 | case AML_METHOD_OP: |
440 | 445 | ||
diff --git a/drivers/acpi/parser/psxface.c b/drivers/acpi/parser/psxface.c index dba893648e84..5279b51e7787 100644 --- a/drivers/acpi/parser/psxface.c +++ b/drivers/acpi/parser/psxface.c | |||
@@ -138,11 +138,14 @@ acpi_psx_execute ( | |||
138 | * objects (such as Operation Regions) can be created during the | 138 | * objects (such as Operation Regions) can be created during the |
139 | * first pass parse. | 139 | * first pass parse. |
140 | */ | 140 | */ |
141 | obj_desc->method.owning_id = acpi_ut_allocate_owner_id (ACPI_OWNER_TYPE_METHOD); | 141 | status = acpi_ut_allocate_owner_id (&obj_desc->method.owner_id); |
142 | if (ACPI_FAILURE (status)) { | ||
143 | goto cleanup2; | ||
144 | } | ||
142 | 145 | ||
143 | /* Create and initialize a new walk state */ | 146 | /* Create and initialize a new walk state */ |
144 | 147 | ||
145 | walk_state = acpi_ds_create_walk_state (obj_desc->method.owning_id, | 148 | walk_state = acpi_ds_create_walk_state (obj_desc->method.owner_id, |
146 | NULL, NULL, NULL); | 149 | NULL, NULL, NULL); |
147 | if (!walk_state) { | 150 | if (!walk_state) { |
148 | status = AE_NO_MEMORY; | 151 | status = AE_NO_MEMORY; |