diff options
| author | Len Brown <len.brown@intel.com> | 2007-05-10 02:49:21 -0400 | 
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2007-05-10 02:49:21 -0400 | 
| commit | 3dd6786f55219f87fd33e153669600d715ca9270 (patch) | |
| tree | 305f8389a93bf86df79f4cf8fb0050b1d6008939 /drivers/acpi/namespace | |
| parent | f697b677620d04d8c77841745727de85f7e948b1 (diff) | |
| parent | 88db5e1489f23876a226f5393fd978ddc09dc5f9 (diff) | |
Pull bugzilla-8385 into release branch
Diffstat (limited to 'drivers/acpi/namespace')
| -rw-r--r-- | drivers/acpi/namespace/nseval.c | 11 | ||||
| -rw-r--r-- | drivers/acpi/namespace/nsinit.c | 7 | ||||
| -rw-r--r-- | drivers/acpi/namespace/nsxfeval.c | 11 | 
3 files changed, 8 insertions, 21 deletions
| diff --git a/drivers/acpi/namespace/nseval.c b/drivers/acpi/namespace/nseval.c index 26fd0dd6953d..aa6370c67ec1 100644 --- a/drivers/acpi/namespace/nseval.c +++ b/drivers/acpi/namespace/nseval.c | |||
| @@ -154,11 +154,7 @@ acpi_status acpi_ns_evaluate(struct acpi_evaluate_info *info) | |||
| 154 | * Execute the method via the interpreter. The interpreter is locked | 154 | * Execute the method via the interpreter. The interpreter is locked | 
| 155 | * here before calling into the AML parser | 155 | * here before calling into the AML parser | 
| 156 | */ | 156 | */ | 
| 157 | status = acpi_ex_enter_interpreter(); | 157 | acpi_ex_enter_interpreter(); | 
| 158 | if (ACPI_FAILURE(status)) { | ||
| 159 | return_ACPI_STATUS(status); | ||
| 160 | } | ||
| 161 | |||
| 162 | status = acpi_ps_execute_method(info); | 158 | status = acpi_ps_execute_method(info); | 
| 163 | acpi_ex_exit_interpreter(); | 159 | acpi_ex_exit_interpreter(); | 
| 164 | } else { | 160 | } else { | 
| @@ -182,10 +178,7 @@ acpi_status acpi_ns_evaluate(struct acpi_evaluate_info *info) | |||
| 182 | * resolution, we must lock it because we could access an opregion. | 178 | * resolution, we must lock it because we could access an opregion. | 
| 183 | * The opregion access code assumes that the interpreter is locked. | 179 | * The opregion access code assumes that the interpreter is locked. | 
| 184 | */ | 180 | */ | 
| 185 | status = acpi_ex_enter_interpreter(); | 181 | acpi_ex_enter_interpreter(); | 
| 186 | if (ACPI_FAILURE(status)) { | ||
| 187 | return_ACPI_STATUS(status); | ||
| 188 | } | ||
| 189 | 182 | ||
| 190 | /* Function has a strange interface */ | 183 | /* Function has a strange interface */ | 
| 191 | 184 | ||
| diff --git a/drivers/acpi/namespace/nsinit.c b/drivers/acpi/namespace/nsinit.c index c4ab615f77fe..33db2241044e 100644 --- a/drivers/acpi/namespace/nsinit.c +++ b/drivers/acpi/namespace/nsinit.c | |||
| @@ -214,7 +214,7 @@ acpi_ns_init_one_object(acpi_handle obj_handle, | |||
| 214 | u32 level, void *context, void **return_value) | 214 | u32 level, void *context, void **return_value) | 
| 215 | { | 215 | { | 
| 216 | acpi_object_type type; | 216 | acpi_object_type type; | 
| 217 | acpi_status status; | 217 | acpi_status status = AE_OK; | 
| 218 | struct acpi_init_walk_info *info = | 218 | struct acpi_init_walk_info *info = | 
| 219 | (struct acpi_init_walk_info *)context; | 219 | (struct acpi_init_walk_info *)context; | 
| 220 | struct acpi_namespace_node *node = | 220 | struct acpi_namespace_node *node = | 
| @@ -268,10 +268,7 @@ acpi_ns_init_one_object(acpi_handle obj_handle, | |||
| 268 | /* | 268 | /* | 
| 269 | * Must lock the interpreter before executing AML code | 269 | * Must lock the interpreter before executing AML code | 
| 270 | */ | 270 | */ | 
| 271 | status = acpi_ex_enter_interpreter(); | 271 | acpi_ex_enter_interpreter(); | 
| 272 | if (ACPI_FAILURE(status)) { | ||
| 273 | return (status); | ||
| 274 | } | ||
| 275 | 272 | ||
| 276 | /* | 273 | /* | 
| 277 | * Each of these types can contain executable AML code within the | 274 | * Each of these types can contain executable AML code within the | 
| diff --git a/drivers/acpi/namespace/nsxfeval.c b/drivers/acpi/namespace/nsxfeval.c index 8904d0fae6a2..7ac6ace50059 100644 --- a/drivers/acpi/namespace/nsxfeval.c +++ b/drivers/acpi/namespace/nsxfeval.c | |||
| @@ -170,7 +170,6 @@ acpi_evaluate_object(acpi_handle handle, | |||
| 170 | struct acpi_buffer *return_buffer) | 170 | struct acpi_buffer *return_buffer) | 
| 171 | { | 171 | { | 
| 172 | acpi_status status; | 172 | acpi_status status; | 
| 173 | acpi_status status2; | ||
| 174 | struct acpi_evaluate_info *info; | 173 | struct acpi_evaluate_info *info; | 
| 175 | acpi_size buffer_space_needed; | 174 | acpi_size buffer_space_needed; | 
| 176 | u32 i; | 175 | u32 i; | 
| @@ -329,14 +328,12 @@ acpi_evaluate_object(acpi_handle handle, | |||
| 329 | * Delete the internal return object. NOTE: Interpreter must be | 328 | * Delete the internal return object. NOTE: Interpreter must be | 
| 330 | * locked to avoid race condition. | 329 | * locked to avoid race condition. | 
| 331 | */ | 330 | */ | 
| 332 | status2 = acpi_ex_enter_interpreter(); | 331 | acpi_ex_enter_interpreter(); | 
| 333 | if (ACPI_SUCCESS(status2)) { | ||
| 334 | 332 | ||
| 335 | /* Remove one reference on the return object (should delete it) */ | 333 | /* Remove one reference on the return object (should delete it) */ | 
| 336 | 334 | ||
| 337 | acpi_ut_remove_reference(info->return_object); | 335 | acpi_ut_remove_reference(info->return_object); | 
| 338 | acpi_ex_exit_interpreter(); | 336 | acpi_ex_exit_interpreter(); | 
| 339 | } | ||
| 340 | } | 337 | } | 
| 341 | 338 | ||
| 342 | cleanup: | 339 | cleanup: | 
