[ACPI] ACPICA 20060210

Removed a couple of extraneous ACPI_ERROR messages that
appeared during normal execution. These became apparent
after the conversion from ACPI_DEBUG_PRINT.

Fixed a problem where the CreateField operator could hang
if the BitIndex or NumBits parameter referred to a named
object. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5359

Fixed a problem where a DeRefOf operation on a buffer
object incorrectly failed with an exception. This also
fixes a couple of related RefOf and DeRefOf issues.
From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5360
http://bugzilla.kernel.org/show_bug.cgi?id=5387
http://bugzilla.kernel.org/show_bug.cgi?id=5392

Fixed a problem where the AE_BUFFER_LIMIT exception was
returned instead of AE_STRING_LIMIT on an out-of-bounds
Index() operation. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5480

Implemented a memory cleanup at the end of the execution
of each iteration of an AML While() loop, preventing the
accumulation of outstanding objects. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5427

Eliminated a chunk of duplicate code in the object
resolution code. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5336

Fixed several warnings during the 64-bit code generation.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

13 files changed, 71 insertions, 21 deletions

diff --git a/drivers/acpi/namespace/nsaccess.c b/drivers/acpi/namespace/nsaccess.c
index 1149bc18fb35..6bdad8bfcf0b 100644
--- a/drivers/acpi/namespace/nsaccess.c
+++ b/drivers/acpi/namespace/nsaccess.c
@@ -98,6 +98,7 @@ acpi_status acpi_ns_root_initialize(void)
                           "Entering predefined entries into namespace\n"));
 
         for (init_val = acpi_gbl_pre_defined_names; init_val->name; init_val++) {
+
                 /* _OSI is optional for now, will be permanent later */
 
                 if (!ACPI_STRCMP(init_val->name, "_OSI")
@@ -365,6 +366,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
          * Begin examination of the actual pathname
          */
         if (!pathname) {
+
                 /* A Null name_path is allowed and refers to the root */
 
                 num_segments = 0;
@@ -389,6 +391,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
                  * to the current scope).
                  */
                 if (*path == (u8) AML_ROOT_PREFIX) {
+
                         /* Pathname is fully qualified, start from the root */
 
                         this_node = acpi_gbl_root_node;
@@ -416,6 +419,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
                         this_node = prefix_node;
                         num_carats = 0;
                         while (*path == (u8) AML_PARENT_PREFIX) {
+
                                 /* Name is fully qualified, no search rules apply */
 
                                 search_parent_flag = ACPI_NS_NO_UPSEARCH;
@@ -430,6 +434,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
                                 num_carats++;
                                 this_node = acpi_ns_get_parent_node(this_node);
                                 if (!this_node) {
+
                                         /* Current scope has no parent scope */
 
                                         ACPI_ERROR((AE_INFO,
@@ -569,6 +574,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
                                              &this_node);
                 if (ACPI_FAILURE(status)) {
                         if (status == AE_NOT_FOUND) {
+
                                 /* Name not found in ACPI namespace */
 
                                 ACPI_DEBUG_PRINT((ACPI_DB_NAMES,
@@ -602,6 +608,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
                     (type_to_check_for != ACPI_TYPE_LOCAL_SCOPE) &&
                     (this_node->type != ACPI_TYPE_ANY) &&
                     (this_node->type != type_to_check_for)) {
+
                         /* Complain about a type mismatch */
 
                         ACPI_WARNING((AE_INFO,
diff --git a/drivers/acpi/namespace/nsalloc.c b/drivers/acpi/namespace/nsalloc.c
index 9b871f38b61b..cd26cb971a1c 100644
--- a/drivers/acpi/namespace/nsalloc.c
+++ b/drivers/acpi/namespace/nsalloc.c
@@ -115,6 +115,7 @@ void acpi_ns_delete_node(struct acpi_namespace_node *node)
         }
 
         if (prev_node) {
+
                 /* Node is not first child, unlink it */
 
                 prev_node->peer = next_node->peer;
@@ -125,6 +126,7 @@ void acpi_ns_delete_node(struct acpi_namespace_node *node)
                 /* Node is first child (has no previous peer) */
 
                 if (next_node->flags & ANOBJ_END_OF_PEER_LIST) {
+
                         /* No peers at all */
 
                         parent_node->child = NULL;
@@ -264,6 +266,7 @@ void acpi_ns_delete_children(struct acpi_namespace_node *parent_node)
          * Deallocate all children at this level
          */
         do {
+
                 /* Get the things we need */
 
                 next_node = child_node->peer;
@@ -352,11 +355,13 @@ void acpi_ns_delete_namespace_subtree(struct acpi_namespace_node *parent_node)
          * to where we started.
          */
         while (level > 0) {
+
                 /* Get the next node in this scope (NULL if none) */
 
                 child_node = acpi_ns_get_next_node(ACPI_TYPE_ANY, parent_node,
                                                    child_node);
                 if (child_node) {
+
                         /* Found a child node - detach any attached object */
 
                         acpi_ns_detach_object(child_node);
@@ -427,6 +432,7 @@ static void acpi_ns_remove_reference(struct acpi_namespace_node *node)
          */
         this_node = node;
         while (this_node) {
+
                 /* Prepare to move up to parent */
 
                 parent_node = acpi_ns_get_parent_node(this_node);
@@ -438,6 +444,7 @@ static void acpi_ns_remove_reference(struct acpi_namespace_node *node)
                 /* Delete the node if no more references */
 
                 if (!this_node->reference_count) {
+
                         /* Delete all children and delete the node */
 
                         acpi_ns_delete_children(this_node);
@@ -500,6 +507,7 @@ void acpi_ns_delete_namespace_by_owner(acpi_owner_id owner_id)
 
                 if (child_node) {
                         if (child_node->owner_id == owner_id) {
+
                                 /* Found a matching child node - detach any attached object */
 
                                 acpi_ns_detach_object(child_node);
diff --git a/drivers/acpi/namespace/nsdump.c b/drivers/acpi/namespace/nsdump.c
index a2807317a84b..e275373b1705 100644
--- a/drivers/acpi/namespace/nsdump.c
+++ b/drivers/acpi/namespace/nsdump.c
@@ -191,6 +191,7 @@ acpi_ns_dump_one_object(acpi_handle obj_handle,
         }
 
         if (!(info->display_type & ACPI_DISPLAY_SHORT)) {
+
                 /* Indent the object according to the level */
 
                 acpi_os_printf("%2d%*s", (u32) level - 1, (int)level * 2, " ");
@@ -226,6 +227,7 @@ acpi_ns_dump_one_object(acpi_handle obj_handle,
         case ACPI_DISPLAY_SUMMARY:
 
                 if (!obj_desc) {
+
                         /* No attached object, we are done */
 
                         acpi_os_printf("\n");
@@ -419,6 +421,7 @@ acpi_ns_dump_one_object(acpi_handle obj_handle,
 
                 acpi_os_printf("O:%p", obj_desc);
                 if (!obj_desc) {
+
                         /* No attached object, we are done */
 
                         acpi_os_printf("\n");
@@ -682,6 +685,7 @@ void acpi_ns_dump_tables(acpi_handle search_base, u32 max_depth)
         }
 
         if (ACPI_NS_ALL == search_base) {
+
                 /* Entire namespace */
 
                 search_handle = acpi_gbl_root_node;
diff --git a/drivers/acpi/namespace/nseval.c b/drivers/acpi/namespace/nseval.c
index 19d7b94d40c3..80ef95545636 100644
--- a/drivers/acpi/namespace/nseval.c
+++ b/drivers/acpi/namespace/nseval.c
@@ -326,6 +326,7 @@ acpi_status acpi_ns_evaluate_by_handle(struct acpi_parameter_info *info)
          * Check if there is a return value on the stack that must be dealt with
          */
         if (status == AE_CTRL_RETURN_VALUE) {
+
                 /* Map AE_CTRL_RETURN_VALUE to AE_OK, we are done with it */
 
                 status = AE_OK;
diff --git a/drivers/acpi/namespace/nsinit.c b/drivers/acpi/namespace/nsinit.c
index 9f929e479fd8..9aa337c33887 100644
--- a/drivers/acpi/namespace/nsinit.c
+++ b/drivers/acpi/namespace/nsinit.c
@@ -366,6 +366,7 @@ acpi_ns_init_one_device(acpi_handle obj_handle,
         status = acpi_ns_search_node(*ACPI_CAST_PTR(u32, METHOD_NAME__INI),
                                      device_node, ACPI_TYPE_METHOD, &ini_node);
         if (ACPI_FAILURE(status)) {
+
                 /* No _INI method found - move on to next device */
 
                 return_ACPI_STATUS(AE_OK);
@@ -386,6 +387,7 @@ acpi_ns_init_one_device(acpi_handle obj_handle,
 
         status = acpi_ut_execute_STA(pinfo.node, &flags);
         if (ACPI_FAILURE(status)) {
+
                 /* Ignore error and move on to next device */
 
                 return_ACPI_STATUS(AE_OK);
@@ -396,6 +398,7 @@ acpi_ns_init_one_device(acpi_handle obj_handle,
         }
 
         if (!(flags & ACPI_STA_DEVICE_PRESENT)) {
+
                 /* Don't look at children of a not present device */
 
                 return_ACPI_STATUS(AE_CTRL_DEPTH);
@@ -412,6 +415,7 @@ acpi_ns_init_one_device(acpi_handle obj_handle,
         pinfo.node = ini_node;
         status = acpi_ns_evaluate_by_handle(&pinfo);
         if (ACPI_FAILURE(status)) {
+
                 /* Ignore error and move on to next device */
 
 #ifdef ACPI_DEBUG_OUTPUT
@@ -435,6 +439,7 @@ acpi_ns_init_one_device(acpi_handle obj_handle,
         }
 
         if (acpi_gbl_init_handler) {
+
                 /* External initialization handler is present, call it */
 
                 status =
diff --git a/drivers/acpi/namespace/nsload.c b/drivers/acpi/namespace/nsload.c
index 4e0b0524c188..80acfd35f3ec 100644
--- a/drivers/acpi/namespace/nsload.c
+++ b/drivers/acpi/namespace/nsload.c
@@ -84,6 +84,7 @@ acpi_ns_load_table(struct acpi_table_desc *table_desc,
         if (!
             (acpi_gbl_table_data[table_desc->type].
              flags & ACPI_TABLE_EXECUTABLE)) {
+
                 /* Just ignore this table */
 
                 return_ACPI_STATUS(AE_OK);
@@ -325,6 +326,7 @@ static acpi_status acpi_ns_delete_subtree(acpi_handle start_handle)
          * to where we started.
          */
         while (level > 0) {
+
                 /* Attempt to get the next object in this scope */
 
                 status = acpi_get_next_object(ACPI_TYPE_ANY, parent_handle,
@@ -335,6 +337,7 @@ static acpi_status acpi_ns_delete_subtree(acpi_handle start_handle)
                 /* Did we get a new object? */
 
                 if (ACPI_SUCCESS(status)) {
+
                         /* Check if this object has any children */
 
                         if (ACPI_SUCCESS
diff --git a/drivers/acpi/namespace/nsobject.c b/drivers/acpi/namespace/nsobject.c
index 10ae6292bca4..39dc87b228fc 100644
--- a/drivers/acpi/namespace/nsobject.c
+++ b/drivers/acpi/namespace/nsobject.c
@@ -82,6 +82,7 @@ acpi_ns_attach_object(struct acpi_namespace_node *node,
          * Parameter validation
          */
         if (!node) {
+
                 /* Invalid handle */
 
                 ACPI_ERROR((AE_INFO, "Null named_obj handle"));
@@ -89,6 +90,7 @@ acpi_ns_attach_object(struct acpi_namespace_node *node,
         }
 
         if (!object && (ACPI_TYPE_ANY != type)) {
+
                 /* Null object */
 
                 ACPI_ERROR((AE_INFO,
@@ -97,6 +99,7 @@ acpi_ns_attach_object(struct acpi_namespace_node *node,
         }
 
         if (ACPI_GET_DESCRIPTOR_TYPE(node) != ACPI_DESC_TYPE_NAMED) {
+
                 /* Not a name handle */
 
                 ACPI_ERROR((AE_INFO, "Invalid handle %p [%s]",
diff --git a/drivers/acpi/namespace/nssearch.c b/drivers/acpi/namespace/nssearch.c
index d64b78952f24..f73a3d566168 100644
--- a/drivers/acpi/namespace/nssearch.c
+++ b/drivers/acpi/namespace/nssearch.c
@@ -114,9 +114,11 @@ acpi_ns_search_node(u32 target_name,
          */
         next_node = node->child;
         while (next_node) {
+
                 /* Check for match against the name */
 
                 if (next_node->name.integer == target_name) {
+
                         /* Resolve a control method alias if any */
 
                         if (acpi_ns_get_type(next_node) ==
@@ -146,6 +148,7 @@ acpi_ns_search_node(u32 target_name,
                  * so a flag is used to indicate the end-of-list
                  */
                 if (next_node->flags & ANOBJ_END_OF_PEER_LIST) {
+
                         /* Searched entire list, we are done */
 
                         break;
diff --git a/drivers/acpi/namespace/nsutils.c b/drivers/acpi/namespace/nsutils.c
index 3e7cad549a38..e8c779114bec 100644
--- a/drivers/acpi/namespace/nsutils.c
+++ b/drivers/acpi/namespace/nsutils.c
@@ -83,6 +83,7 @@ acpi_ns_report_error(char *module_name,
         acpi_ut_report_error(module_name, line_number);
 
         if (lookup_status == AE_BAD_CHARACTER) {
+
                 /* There is a non-ascii character in the name */
 
                 acpi_os_printf("[0x%4.4X] (NON-ASCII)",
@@ -267,6 +268,7 @@ u32 acpi_ns_local(acpi_object_type type)
         ACPI_FUNCTION_TRACE("ns_local");
 
         if (!acpi_ut_valid_object_type(type)) {
+
                 /* Type code out of range  */
 
                 ACPI_WARNING((AE_INFO, "Invalid Object Type %X", type));
@@ -411,6 +413,7 @@ acpi_status acpi_ns_build_internal_name(struct acpi_namestring_info *info)
                 for (i = 0; i < ACPI_NAME_SIZE; i++) {
                         if (acpi_ns_valid_path_separator(*external_name) ||
                             (*external_name == 0)) {
+
                                 /* Pad the segment with underscore(s) if segment is short */
 
                                 result[i] = '_';
@@ -795,6 +798,7 @@ u32 acpi_ns_opens_scope(acpi_object_type type)
         ACPI_FUNCTION_TRACE_STR("ns_opens_scope", acpi_ut_get_type_name(type));
 
         if (!acpi_ut_valid_object_type(type)) {
+
                 /* type code out of range  */
 
                 ACPI_WARNING((AE_INFO, "Invalid Object Type %X", type));
@@ -838,6 +842,7 @@ acpi_ns_get_node_by_path(char *pathname,
         ACPI_FUNCTION_TRACE_PTR("ns_get_node_by_path", pathname);
 
         if (pathname) {
+
                 /* Convert path to internal representation */
 
                 status = acpi_ns_internalize_name(pathname, &internal_path);
@@ -963,6 +968,7 @@ acpi_name acpi_ns_find_parent_name(struct acpi_namespace_node * child_node)
         ACPI_FUNCTION_TRACE("ns_find_parent_name");
 
         if (child_node) {
+
                 /* Valid entry.  Get the parent Node */
 
                 parent_node = acpi_ns_get_parent_node(child_node);
diff --git a/drivers/acpi/namespace/nswalk.c b/drivers/acpi/namespace/nswalk.c
index fcab1e784b81..6bbc734bfee2 100644
--- a/drivers/acpi/namespace/nswalk.c
+++ b/drivers/acpi/namespace/nswalk.c
@@ -76,6 +76,7 @@ struct acpi_namespace_node *acpi_ns_get_next_node(acpi_object_type type,
         ACPI_FUNCTION_ENTRY();
 
         if (!child_node) {
+
                 /* It's really the parent's _scope_ that we want */
 
                 if (parent_node->child) {
@@ -92,6 +93,7 @@ struct acpi_namespace_node *acpi_ns_get_next_node(acpi_object_type type,
         /* If any type is OK, we are done */
 
         if (type == ACPI_TYPE_ANY) {
+
                 /* next_node is NULL if we are at the end-of-list */
 
                 return (next_node);
@@ -100,6 +102,7 @@ struct acpi_namespace_node *acpi_ns_get_next_node(acpi_object_type type,
         /* Must search for the node -- but within this scope only */
 
         while (next_node) {
+
                 /* If type matches, we are done */
 
                 if (next_node->type == type) {
@@ -182,6 +185,7 @@ acpi_ns_walk_namespace(acpi_object_type type,
          * bubbled up to (and passed) the original parent handle (start_entry)
          */
         while (level > 0) {
+
                 /* Get the next node in this scope.  Null if not found */
 
                 status = AE_OK;
diff --git a/drivers/acpi/namespace/nsxfeval.c b/drivers/acpi/namespace/nsxfeval.c
index a95f636dc35d..71e7769d7daf 100644
--- a/drivers/acpi/namespace/nsxfeval.c
+++ b/drivers/acpi/namespace/nsxfeval.c
@@ -110,6 +110,7 @@ acpi_evaluate_object_typed(acpi_handle handle,
         }
 
         if (return_buffer->length == 0) {
+
                 /* Error because caller specifically asked for a return value */
 
                 ACPI_ERROR((AE_INFO, "No return value"));
@@ -131,6 +132,7 @@ acpi_evaluate_object_typed(acpi_handle handle,
                     acpi_ut_get_type_name(return_type)));
 
         if (must_free) {
+
                 /* Caller used ACPI_ALLOCATE_BUFFER, free the return buffer */
 
                 acpi_os_free(return_buffer->pointer);
@@ -224,9 +226,9 @@ acpi_evaluate_object(acpi_handle handle,
          * 3) Valid handle
          */
         if ((pathname) && (acpi_ns_valid_root_prefix(pathname[0]))) {
-                /*
-                 *  The path is fully qualified, just evaluate by name
-                 */
+
+                /* The path is fully qualified, just evaluate by name */
+
                 status = acpi_ns_evaluate_by_name(pathname, &info);
         } else if (!handle) {
                 /*
@@ -235,11 +237,12 @@ acpi_evaluate_object(acpi_handle handle,
                  * qualified names above, this is an error
                  */
                 if (!pathname) {
-                        ACPI_ERROR((AE_INFO,
-                                    "Both Handle and Pathname are NULL"));
+                        ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+                                          "Both Handle and Pathname are NULL"));
                 } else {
-                        ACPI_ERROR((AE_INFO,
-                                    "Handle is NULL and Pathname is relative"));
+                        ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+                                          "Null Handle with relative pathname [%s]",
+                                          pathname));
                 }
 
                 status = AE_BAD_PARAMETER;
@@ -256,9 +259,8 @@ acpi_evaluate_object(acpi_handle handle,
                          */
                         status = acpi_ns_evaluate_by_handle(&info);
                 } else {
-                        /*
-                         * Both a Handle and a relative Pathname
-                         */
+                        /* Both a Handle and a relative Pathname */
+
                         status = acpi_ns_evaluate_relative(pathname, &info);
                 }
         }
@@ -295,6 +297,7 @@ acpi_evaluate_object(acpi_handle handle,
                                     acpi_ut_get_object_size(info.return_object,
                                                             &buffer_space_needed);
                                 if (ACPI_SUCCESS(status)) {
+
                                         /* Validate/Allocate/Clear caller buffer */
 
                                         status =
@@ -303,7 +306,8 @@ acpi_evaluate_object(acpi_handle handle,
                                              buffer_space_needed);
                                         if (ACPI_FAILURE(status)) {
                                                 /*
-                                                 * Caller's buffer is too small or a new one can't be allocated
+                                                 * Caller's buffer is too small or a new one can't
+                                                 * be allocated
                                                  */
                                                 ACPI_DEBUG_PRINT((ACPI_DB_INFO,
                                                                   "Needed buffer size %X, %s\n",
@@ -312,9 +316,8 @@ acpi_evaluate_object(acpi_handle handle,
                                                                   acpi_format_exception
                                                                   (status)));
                                         } else {
-                                                /*
-                                                 *  We have enough space for the object, build it
-                                                 */
+                                                /* We have enough space for the object, build it */
+
                                                 status =
                                                     acpi_ut_copy_iobject_to_eobject
                                                     (info.return_object,
@@ -341,10 +344,10 @@ acpi_evaluate_object(acpi_handle handle,
                 }
         }
 
-        /*
-         * Free the input parameter list (if we created one),
-         */
+        /* Free the input parameter list (if we created one) */
+
         if (info.parameters) {
+
                 /* Free the allocated parameter block */
 
                 acpi_ut_delete_internal_object_list(info.parameters);
@@ -473,6 +476,7 @@ acpi_ns_get_device_callback(acpi_handle obj_handle,
         }
 
         if (!(flags & ACPI_STA_DEVICE_PRESENT)) {
+
                 /* Don't examine children of the device if not present */
 
                 return (AE_CTRL_DEPTH);
@@ -489,6 +493,7 @@ acpi_ns_get_device_callback(acpi_handle obj_handle,
                 }
 
                 if (ACPI_STRNCMP(hid.value, info->hid, sizeof(hid.value)) != 0) {
+
                         /* Get the list of Compatible IDs */
 
                         status = acpi_ut_execute_CID(node, &cid);
@@ -563,9 +568,9 @@ acpi_get_devices(char *HID,
          * We're going to call their callback from OUR callback, so we need
          * to know what it is, and their context parameter.
          */
+        info.hid = HID;
         info.context = context;
         info.user_function = user_function;
-        info.hid = HID;
 
         /*
          * Lock the namespace around the walk.
@@ -578,9 +583,8 @@ acpi_get_devices(char *HID,
                 return_ACPI_STATUS(status);
         }
 
-        status = acpi_ns_walk_namespace(ACPI_TYPE_DEVICE,
-                                        ACPI_ROOT_OBJECT, ACPI_UINT32_MAX,
-                                        ACPI_NS_WALK_UNLOCK,
+        status = acpi_ns_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
+                                        ACPI_UINT32_MAX, ACPI_NS_WALK_UNLOCK,
                                         acpi_ns_get_device_callback, &info,
                                         return_value);
 
diff --git a/drivers/acpi/namespace/nsxfname.c b/drivers/acpi/namespace/nsxfname.c
index 8cd8675a47c0..55d26624ab9f 100644
--- a/drivers/acpi/namespace/nsxfname.c
+++ b/drivers/acpi/namespace/nsxfname.c
@@ -162,6 +162,7 @@ acpi_get_name(acpi_handle handle, u32 name_type, struct acpi_buffer * buffer)
         }
 
         if (name_type == ACPI_FULL_PATHNAME) {
+
                 /* Get the full pathname (From the namespace root) */
 
                 status = acpi_ns_handle_to_pathname(handle, buffer);
diff --git a/drivers/acpi/namespace/nsxfobj.c b/drivers/acpi/namespace/nsxfobj.c
index a0332595677a..9c5f3302799c 100644
--- a/drivers/acpi/namespace/nsxfobj.c
+++ b/drivers/acpi/namespace/nsxfobj.c
@@ -206,6 +206,7 @@ acpi_get_next_object(acpi_object_type type,
         /* If null handle, use the parent */
 
         if (!child) {
+
                 /* Start search at the beginning of the specified scope */
 
                 parent_node = acpi_ns_map_handle_to_node(parent);