ACPICA: Fix possible fault for methods that optionally have no return value.

Currently applies to the _WAK method only. If the method has no return
value and slack mode is not enabled, the return value validation code
can fault.

Also improves the error message when an expected return value is
missing (for any predefined name/method).

The problem fixed here cannot happen on Linux unless acpi=strict is
added to the kernel command line.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

1 files changed, 15 insertions, 1 deletions

diff --git a/drivers/acpi/acpica/nspredef.c b/drivers/acpi/acpica/nspredef.c
index 24b71a01bf93..098e7666cbc9 100644
--- a/drivers/acpi/acpica/nspredef.c
+++ b/drivers/acpi/acpica/nspredef.c
@@ -151,6 +151,15 @@ acpi_ns_check_return_value(struct acpi_namespace_node *node,
         }
 
         /*
+         *
+         * 4) If there is no return value and it is optional, just return
+         * AE_OK (_WAK).
+         */
+        if (!(*return_object_ptr)) {
+                goto exit;
+        }
+
+        /*
          * For returned Package objects, check the type of all sub-objects.
          * Note: Package may have been newly created by call above.
          */
@@ -268,7 +277,12 @@ acpi_ns_check_object_type(struct acpi_evaluate_info *info,
 
         acpi_ut_get_expected_return_types(type_buffer, expected_btypes);
 
-        if (package_index == ACPI_NOT_PACKAGE_ELEMENT) {
+        if (!return_object) {
+                ACPI_WARN_PREDEFINED((AE_INFO, info->full_pathname,
+                                      info->node_flags,
+                                      "Expected return object of type %s",
+                                      type_buffer));
+        } else if (package_index == ACPI_NOT_PACKAGE_ELEMENT) {
                 ACPI_WARN_PREDEFINED((AE_INFO, info->full_pathname,
                                       info->node_flags,
                                       "Return type mismatch - found %s, expected %s",