ACPICA: Enhance error reporting for invalid opcodes and bad ACPI_NAMEs

For disassembler, dump the 48 bytes surrounding the invalid
opcode.  Fix incorrect table offset reported for invalid opcodes.
Report original 32-bit value for bad ACPI_NAMEs.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

1 files changed, 5 insertions, 4 deletions

diff --git a/drivers/acpi/acpica/nsutils.c b/drivers/acpi/acpica/nsutils.c
index 16b3da80b92d..0d3d481ce58e 100644
--- a/drivers/acpi/acpica/nsutils.c
+++ b/drivers/acpi/acpica/nsutils.c
@@ -557,10 +557,11 @@ acpi_ns_externalize_name(u32 internal_name_length,
                                 (*converted_name)[j++] = '.';
                         }
 
-                        (*converted_name)[j++] = internal_name[names_index++];
-                        (*converted_name)[j++] = internal_name[names_index++];
-                        (*converted_name)[j++] = internal_name[names_index++];
-                        (*converted_name)[j++] = internal_name[names_index++];
+                        ACPI_MOVE_NAME(*converted_name, internal_name);
+                        acpi_ut_repair_name(*converted_name);
+
+                        j += ACPI_NAME_SIZE;
+                        names_index += ACPI_NAME_SIZE;
                 }
         }