diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/tea.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/tea.c')
-rw-r--r-- | crypto/tea.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/tea.c b/crypto/tea.c index 6893b3fdf9d6..412bc74f8179 100644 --- a/crypto/tea.c +++ b/crypto/tea.c | |||
@@ -267,7 +267,7 @@ static struct crypto_alg xeta_alg = { | |||
267 | .cia_decrypt = xeta_decrypt } } | 267 | .cia_decrypt = xeta_decrypt } } |
268 | }; | 268 | }; |
269 | 269 | ||
270 | static int __init init(void) | 270 | static int __init tea_mod_init(void) |
271 | { | 271 | { |
272 | int ret = 0; | 272 | int ret = 0; |
273 | 273 | ||
@@ -292,7 +292,7 @@ out: | |||
292 | return ret; | 292 | return ret; |
293 | } | 293 | } |
294 | 294 | ||
295 | static void __exit fini(void) | 295 | static void __exit tea_mod_fini(void) |
296 | { | 296 | { |
297 | crypto_unregister_alg(&tea_alg); | 297 | crypto_unregister_alg(&tea_alg); |
298 | crypto_unregister_alg(&xtea_alg); | 298 | crypto_unregister_alg(&xtea_alg); |
@@ -302,8 +302,8 @@ static void __exit fini(void) | |||
302 | MODULE_ALIAS("xtea"); | 302 | MODULE_ALIAS("xtea"); |
303 | MODULE_ALIAS("xeta"); | 303 | MODULE_ALIAS("xeta"); |
304 | 304 | ||
305 | module_init(init); | 305 | module_init(tea_mod_init); |
306 | module_exit(fini); | 306 | module_exit(tea_mod_fini); |
307 | 307 | ||
308 | MODULE_LICENSE("GPL"); | 308 | MODULE_LICENSE("GPL"); |
309 | MODULE_DESCRIPTION("TEA, XTEA & XETA Cryptographic Algorithms"); | 309 | MODULE_DESCRIPTION("TEA, XTEA & XETA Cryptographic Algorithms"); |