diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/tcrypt.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/tcrypt.c')
-rw-r--r-- | crypto/tcrypt.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 689482cd16c2..6beabc5abd07 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c | |||
@@ -1810,7 +1810,7 @@ static void do_test(void) | |||
1810 | } | 1810 | } |
1811 | } | 1811 | } |
1812 | 1812 | ||
1813 | static int __init init(void) | 1813 | static int __init tcrypt_mod_init(void) |
1814 | { | 1814 | { |
1815 | int err = -ENOMEM; | 1815 | int err = -ENOMEM; |
1816 | 1816 | ||
@@ -1849,10 +1849,10 @@ static int __init init(void) | |||
1849 | * If an init function is provided, an exit function must also be provided | 1849 | * If an init function is provided, an exit function must also be provided |
1850 | * to allow module unload. | 1850 | * to allow module unload. |
1851 | */ | 1851 | */ |
1852 | static void __exit fini(void) { } | 1852 | static void __exit tcrypt_mod_fini(void) { } |
1853 | 1853 | ||
1854 | module_init(init); | 1854 | module_init(tcrypt_mod_init); |
1855 | module_exit(fini); | 1855 | module_exit(tcrypt_mod_fini); |
1856 | 1856 | ||
1857 | module_param(mode, int, 0); | 1857 | module_param(mode, int, 0); |
1858 | module_param(sec, uint, 0); | 1858 | module_param(sec, uint, 0); |