crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/crypto/shash.c b/crypto/shash.c
index 21fc12e2378f..32067f47e6c7 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -534,9 +534,9 @@ static int crypto_shash_report(struct sk_buff *skb, struct crypto_alg *alg)
         rhash.blocksize = alg->cra_blocksize;
         rhash.digestsize = salg->digestsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_HASH,
-                sizeof(struct crypto_report_hash), &rhash);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_HASH,
+                    sizeof(struct crypto_report_hash), &rhash))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: