diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/sha512_generic.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/sha512_generic.c')
-rw-r--r-- | crypto/sha512_generic.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/sha512_generic.c b/crypto/sha512_generic.c index 82add4bf329a..bc3686138aeb 100644 --- a/crypto/sha512_generic.c +++ b/crypto/sha512_generic.c | |||
@@ -278,7 +278,7 @@ static struct crypto_alg sha384 = { | |||
278 | } | 278 | } |
279 | }; | 279 | }; |
280 | 280 | ||
281 | static int __init init(void) | 281 | static int __init sha512_generic_mod_init(void) |
282 | { | 282 | { |
283 | int ret = 0; | 283 | int ret = 0; |
284 | 284 | ||
@@ -290,14 +290,14 @@ out: | |||
290 | return ret; | 290 | return ret; |
291 | } | 291 | } |
292 | 292 | ||
293 | static void __exit fini(void) | 293 | static void __exit sha512_generic_mod_fini(void) |
294 | { | 294 | { |
295 | crypto_unregister_alg(&sha384); | 295 | crypto_unregister_alg(&sha384); |
296 | crypto_unregister_alg(&sha512); | 296 | crypto_unregister_alg(&sha512); |
297 | } | 297 | } |
298 | 298 | ||
299 | module_init(init); | 299 | module_init(sha512_generic_mod_init); |
300 | module_exit(fini); | 300 | module_exit(sha512_generic_mod_fini); |
301 | 301 | ||
302 | MODULE_LICENSE("GPL"); | 302 | MODULE_LICENSE("GPL"); |
303 | MODULE_DESCRIPTION("SHA-512 and SHA-384 Secure Hash Algorithms"); | 303 | MODULE_DESCRIPTION("SHA-512 and SHA-384 Secure Hash Algorithms"); |