diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/sha256_generic.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/sha256_generic.c')
-rw-r--r-- | crypto/sha256_generic.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/sha256_generic.c b/crypto/sha256_generic.c index 3cc93fd61043..5a8dd47558e5 100644 --- a/crypto/sha256_generic.c +++ b/crypto/sha256_generic.c | |||
@@ -353,7 +353,7 @@ static struct crypto_alg sha224 = { | |||
353 | .dia_final = sha224_final } } | 353 | .dia_final = sha224_final } } |
354 | }; | 354 | }; |
355 | 355 | ||
356 | static int __init init(void) | 356 | static int __init sha256_generic_mod_init(void) |
357 | { | 357 | { |
358 | int ret = 0; | 358 | int ret = 0; |
359 | 359 | ||
@@ -370,14 +370,14 @@ static int __init init(void) | |||
370 | return ret; | 370 | return ret; |
371 | } | 371 | } |
372 | 372 | ||
373 | static void __exit fini(void) | 373 | static void __exit sha256_generic_mod_fini(void) |
374 | { | 374 | { |
375 | crypto_unregister_alg(&sha224); | 375 | crypto_unregister_alg(&sha224); |
376 | crypto_unregister_alg(&sha256); | 376 | crypto_unregister_alg(&sha256); |
377 | } | 377 | } |
378 | 378 | ||
379 | module_init(init); | 379 | module_init(sha256_generic_mod_init); |
380 | module_exit(fini); | 380 | module_exit(sha256_generic_mod_fini); |
381 | 381 | ||
382 | MODULE_LICENSE("GPL"); | 382 | MODULE_LICENSE("GPL"); |
383 | MODULE_DESCRIPTION("SHA-224 and SHA-256 Secure Hash Algorithm"); | 383 | MODULE_DESCRIPTION("SHA-224 and SHA-256 Secure Hash Algorithm"); |