diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/sha1_generic.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/sha1_generic.c')
-rw-r--r-- | crypto/sha1_generic.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/sha1_generic.c b/crypto/sha1_generic.c index 68c62f528eb5..c7c6899e1fca 100644 --- a/crypto/sha1_generic.c +++ b/crypto/sha1_generic.c | |||
@@ -120,18 +120,18 @@ static struct crypto_alg alg = { | |||
120 | .dia_final = sha1_final } } | 120 | .dia_final = sha1_final } } |
121 | }; | 121 | }; |
122 | 122 | ||
123 | static int __init init(void) | 123 | static int __init sha1_generic_mod_init(void) |
124 | { | 124 | { |
125 | return crypto_register_alg(&alg); | 125 | return crypto_register_alg(&alg); |
126 | } | 126 | } |
127 | 127 | ||
128 | static void __exit fini(void) | 128 | static void __exit sha1_generic_mod_fini(void) |
129 | { | 129 | { |
130 | crypto_unregister_alg(&alg); | 130 | crypto_unregister_alg(&alg); |
131 | } | 131 | } |
132 | 132 | ||
133 | module_init(init); | 133 | module_init(sha1_generic_mod_init); |
134 | module_exit(fini); | 134 | module_exit(sha1_generic_mod_fini); |
135 | 135 | ||
136 | MODULE_LICENSE("GPL"); | 136 | MODULE_LICENSE("GPL"); |
137 | MODULE_DESCRIPTION("SHA1 Secure Hash Algorithm"); | 137 | MODULE_DESCRIPTION("SHA1 Secure Hash Algorithm"); |