diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/salsa20_generic.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/salsa20_generic.c')
-rw-r--r-- | crypto/salsa20_generic.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/salsa20_generic.c b/crypto/salsa20_generic.c index 1fa4e4ddcab5..b07d55981741 100644 --- a/crypto/salsa20_generic.c +++ b/crypto/salsa20_generic.c | |||
@@ -237,18 +237,18 @@ static struct crypto_alg alg = { | |||
237 | } | 237 | } |
238 | }; | 238 | }; |
239 | 239 | ||
240 | static int __init init(void) | 240 | static int __init salsa20_generic_mod_init(void) |
241 | { | 241 | { |
242 | return crypto_register_alg(&alg); | 242 | return crypto_register_alg(&alg); |
243 | } | 243 | } |
244 | 244 | ||
245 | static void __exit fini(void) | 245 | static void __exit salsa20_generic_mod_fini(void) |
246 | { | 246 | { |
247 | crypto_unregister_alg(&alg); | 247 | crypto_unregister_alg(&alg); |
248 | } | 248 | } |
249 | 249 | ||
250 | module_init(init); | 250 | module_init(salsa20_generic_mod_init); |
251 | module_exit(fini); | 251 | module_exit(salsa20_generic_mod_fini); |
252 | 252 | ||
253 | MODULE_LICENSE("GPL"); | 253 | MODULE_LICENSE("GPL"); |
254 | MODULE_DESCRIPTION ("Salsa20 stream cipher algorithm"); | 254 | MODULE_DESCRIPTION ("Salsa20 stream cipher algorithm"); |