crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/crypto/pcompress.c b/crypto/pcompress.c
index 2e458e5482d0..04e083ff5373 100644
--- a/crypto/pcompress.c
+++ b/crypto/pcompress.c
@@ -55,9 +55,9 @@ static int crypto_pcomp_report(struct sk_buff *skb, struct crypto_alg *alg)
 
         snprintf(rpcomp.type, CRYPTO_MAX_ALG_NAME, "%s", "pcomp");
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_COMPRESS,
-                sizeof(struct crypto_report_comp), &rpcomp);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_COMPRESS,
+                    sizeof(struct crypto_report_comp), &rpcomp))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: