aboutsummaryrefslogtreecommitdiffstats
path: root/crypto/hash.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2008-07-07 08:23:56 -0400
committerHerbert Xu <herbert@gondor.apana.org.au>2008-07-10 08:35:17 -0400
commitca786dc738f4f583b57b1bba7a335b5e8233f4b0 (patch)
treee2e6178fac1d9b3ac2b557cac76977e15f7d5d2c /crypto/hash.c
parentcaee16883a235b1b042282276859e7d5901fad21 (diff)
crypto: hash - Fixed digest size check
The digest size check on hash algorithms is incorrect. It's perfectly valid for hash algorithms to have a digest length longer than their block size. For example crc32c has a block size of 1 and a digest size of 4. Rather than having it lie about its block size, this patch fixes the checks to do what they really should which is to bound the digest size so that code placing the digest on the stack continue to work. HMAC however still needs to check this as it's only defined for such algorithms. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/hash.c')
-rw-r--r--crypto/hash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/hash.c b/crypto/hash.c
index f9400a014e74..0d7caa9ab748 100644
--- a/crypto/hash.c
+++ b/crypto/hash.c
@@ -152,7 +152,7 @@ static int crypto_init_hash_ops(struct crypto_tfm *tfm, u32 type, u32 mask)
152{ 152{
153 struct hash_alg *alg = &tfm->__crt_alg->cra_hash; 153 struct hash_alg *alg = &tfm->__crt_alg->cra_hash;
154 154
155 if (alg->digestsize > crypto_tfm_alg_blocksize(tfm)) 155 if (alg->digestsize > PAGE_SIZE / 8)
156 return -EINVAL; 156 return -EINVAL;
157 157
158 if ((mask & CRYPTO_ALG_TYPE_HASH_MASK) != CRYPTO_ALG_TYPE_HASH_MASK) 158 if ((mask & CRYPTO_ALG_TYPE_HASH_MASK) != CRYPTO_ALG_TYPE_HASH_MASK)