[CRYPTO] api: Get rid of flags argument to setkey

Now that the tfm is passed directly to setkey instead of the ctx, we no
longer need to pass the &tfm->crt_flags pointer.

This patch also gets rid of a few unnecessary checks on the key length
for ciphers as the cipher layer guarantees that the key length is within
the bounds specified by the algorithm.

Rather than testing dia_setkey every time, this patch does it only once
during crypto_alloc_tfm.  The redundant check from crypto_digest_setkey
is also removed.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

1 files changed, 10 insertions, 5 deletions

diff --git a/crypto/digest.c b/crypto/digest.c
index 603006a7bef2..0df7f392a56a 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -76,12 +76,16 @@ static void final(struct crypto_tfm *tfm, u8 *out)
                 tfm->__crt_alg->cra_digest.dia_final(tfm, out);
 }
 
+static int nosetkey(struct crypto_tfm *tfm, const u8 *key, unsigned int keylen)
+{
+        tfm->crt_flags &= ~CRYPTO_TFM_RES_MASK;
+        return -ENOSYS;
+}
+
 static int setkey(struct crypto_tfm *tfm, const u8 *key, unsigned int keylen)
 {
-        u32 flags;
-        if (tfm->__crt_alg->cra_digest.dia_setkey == NULL)
-                return -ENOSYS;
-        return tfm->__crt_alg->cra_digest.dia_setkey(tfm, key, keylen, &flags);
+        tfm->crt_flags &= ~CRYPTO_TFM_RES_MASK;
+        return tfm->__crt_alg->cra_digest.dia_setkey(tfm, key, keylen);
 }
 
 static void digest(struct crypto_tfm *tfm,
@@ -100,12 +104,13 @@ int crypto_init_digest_flags(struct crypto_tfm *tfm, u32 flags)
 int crypto_init_digest_ops(struct crypto_tfm *tfm)
 {
         struct digest_tfm *ops = &tfm->crt_digest;
+        struct digest_alg *dalg = &tfm->__crt_alg->cra_digest;
         
         ops->dit_init   = init;
         ops->dit_update = update;
         ops->dit_final  = final;
         ops->dit_digest = digest;
-        ops->dit_setkey = setkey;
+        ops->dit_setkey = dalg->dia_setkey ? setkey : nosetkey;
         
         return crypto_alloc_hmac_block(tfm);
 }