diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2012-02-24 09:30:15 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-02-26 14:10:06 -0500 |
commit | 80d326fab534a5380e8f6e509a0b9076655a9670 (patch) | |
tree | 57c636de934b3f8abb7db9bcde64360ecc4eaf66 /crypto/crypto_user.c | |
parent | 48e316bc2e045206248c6c75c0d5bbc0c9ddc32c (diff) |
netlink: add netlink_dump_control structure for netlink_dump_start()
Davem considers that the argument list of this interface is getting
out of control. This patch tries to address this issue following
his proposal:
struct netlink_dump_control c = { .dump = dump, .done = done, ... };
netlink_dump_start(..., &c);
Suggested by David S. Miller.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/crypto_user.c')
-rw-r--r-- | crypto/crypto_user.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index 16f8693cc147..b6ac1387770c 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c | |||
@@ -389,9 +389,13 @@ static int crypto_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh) | |||
389 | (nlh->nlmsg_flags & NLM_F_DUMP))) { | 389 | (nlh->nlmsg_flags & NLM_F_DUMP))) { |
390 | if (link->dump == NULL) | 390 | if (link->dump == NULL) |
391 | return -EINVAL; | 391 | return -EINVAL; |
392 | 392 | { | |
393 | return netlink_dump_start(crypto_nlsk, skb, nlh, | 393 | struct netlink_dump_control c = { |
394 | link->dump, link->done, 0); | 394 | .dump = link->dump, |
395 | .done = link->done, | ||
396 | }; | ||
397 | return netlink_dump_start(crypto_nlsk, skb, nlh, &c); | ||
398 | } | ||
395 | } | 399 | } |
396 | 400 | ||
397 | err = nlmsg_parse(nlh, crypto_msg_min[type], attrs, CRYPTOCFGA_MAX, | 401 | err = nlmsg_parse(nlh, crypto_msg_min[type], attrs, CRYPTOCFGA_MAX, |