diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2012-09-07 16:12:54 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-09-10 15:30:41 -0400 |
commit | 15e473046cb6e5d18a4d0057e61d76315230382b (patch) | |
tree | 893d2df5d46a6ce156933ac57a1398f0ad22b889 /crypto/crypto_user.c | |
parent | 9f00d9776bc5beb92e8bfc884a7e96ddc5589e2e (diff) |
netlink: Rename pid to portid to avoid confusion
It is a frequent mistake to confuse the netlink port identifier with a
process identifier. Try to reduce this confusion by renaming fields
that hold port identifiers portid instead of pid.
I have carefully avoided changing the structures exported to
userspace to avoid changing the userspace API.
I have successfully built an allyesconfig kernel with this change.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/crypto_user.c')
-rw-r--r-- | crypto/crypto_user.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index 165914e63ef2..6bba414d0c61 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c | |||
@@ -166,7 +166,7 @@ static int crypto_report_alg(struct crypto_alg *alg, | |||
166 | struct crypto_user_alg *ualg; | 166 | struct crypto_user_alg *ualg; |
167 | int err = 0; | 167 | int err = 0; |
168 | 168 | ||
169 | nlh = nlmsg_put(skb, NETLINK_CB(in_skb).pid, info->nlmsg_seq, | 169 | nlh = nlmsg_put(skb, NETLINK_CB(in_skb).portid, info->nlmsg_seq, |
170 | CRYPTO_MSG_GETALG, sizeof(*ualg), info->nlmsg_flags); | 170 | CRYPTO_MSG_GETALG, sizeof(*ualg), info->nlmsg_flags); |
171 | if (!nlh) { | 171 | if (!nlh) { |
172 | err = -EMSGSIZE; | 172 | err = -EMSGSIZE; |
@@ -216,7 +216,7 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, | |||
216 | if (err) | 216 | if (err) |
217 | return err; | 217 | return err; |
218 | 218 | ||
219 | return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).pid); | 219 | return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid); |
220 | } | 220 | } |
221 | 221 | ||
222 | static int crypto_dump_report(struct sk_buff *skb, struct netlink_callback *cb) | 222 | static int crypto_dump_report(struct sk_buff *skb, struct netlink_callback *cb) |