diff options
author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2008-04-05 09:00:57 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2008-04-20 22:19:34 -0400 |
commit | 3af5b90bde5000abc739996cb03fd718e753d053 (patch) | |
tree | 579ab3154c56dfa49e83acb463f04daed8135988 /crypto/crypto_null.c | |
parent | 7dc748e4e720c1a98185363096ad7582e9113092 (diff) |
[CRYPTO] all: Clean up init()/fini()
On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> > This patch cleanups the crypto code, replaces the init() and fini()
> > with the <algorithm name>_init/_fini
>
> This part ist OK.
>
> > or init/fini_<algorithm name> (if the
> > <algorithm name>_init/_fini exist)
>
> Having init_foo and foo_init won't be a good thing, will it? I'd start
> confusing them.
>
> What about foo_modinit instead?
Thanks for the suggestion, the init() is replaced with
<algorithm name>_mod_init ()
and fini () is replaced with <algorithm name>_mod_fini.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/crypto_null.c')
-rw-r--r-- | crypto/crypto_null.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/crypto_null.c b/crypto/crypto_null.c index ff7b3de1bcfd..1f7d53013a22 100644 --- a/crypto/crypto_null.c +++ b/crypto/crypto_null.c | |||
@@ -142,7 +142,7 @@ MODULE_ALIAS("compress_null"); | |||
142 | MODULE_ALIAS("digest_null"); | 142 | MODULE_ALIAS("digest_null"); |
143 | MODULE_ALIAS("cipher_null"); | 143 | MODULE_ALIAS("cipher_null"); |
144 | 144 | ||
145 | static int __init init(void) | 145 | static int __init crypto_null_mod_init(void) |
146 | { | 146 | { |
147 | int ret = 0; | 147 | int ret = 0; |
148 | 148 | ||
@@ -174,7 +174,7 @@ out_unregister_cipher: | |||
174 | goto out; | 174 | goto out; |
175 | } | 175 | } |
176 | 176 | ||
177 | static void __exit fini(void) | 177 | static void __exit crypto_null_mod_fini(void) |
178 | { | 178 | { |
179 | crypto_unregister_alg(&compress_null); | 179 | crypto_unregister_alg(&compress_null); |
180 | crypto_unregister_alg(&digest_null); | 180 | crypto_unregister_alg(&digest_null); |
@@ -182,8 +182,8 @@ static void __exit fini(void) | |||
182 | crypto_unregister_alg(&cipher_null); | 182 | crypto_unregister_alg(&cipher_null); |
183 | } | 183 | } |
184 | 184 | ||
185 | module_init(init); | 185 | module_init(crypto_null_mod_init); |
186 | module_exit(fini); | 186 | module_exit(crypto_null_mod_fini); |
187 | 187 | ||
188 | MODULE_LICENSE("GPL"); | 188 | MODULE_LICENSE("GPL"); |
189 | MODULE_DESCRIPTION("Null Cryptographic Algorithms"); | 189 | MODULE_DESCRIPTION("Null Cryptographic Algorithms"); |