crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c
index 4dd80c725498..a8d85a1d670e 100644
--- a/crypto/blkcipher.c
+++ b/crypto/blkcipher.c
@@ -508,9 +508,9 @@ static int crypto_blkcipher_report(struct sk_buff *skb, struct crypto_alg *alg)
         rblkcipher.max_keysize = alg->cra_blkcipher.max_keysize;
         rblkcipher.ivsize = alg->cra_blkcipher.ivsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_BLKCIPHER,
-                sizeof(struct crypto_report_blkcipher), &rblkcipher);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_BLKCIPHER,
+                    sizeof(struct crypto_report_blkcipher), &rblkcipher))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: