crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/crypto/ahash.c b/crypto/ahash.c
index 33bc9b62e9ae..3887856c2dd6 100644
--- a/crypto/ahash.c
+++ b/crypto/ahash.c
@@ -409,9 +409,9 @@ static int crypto_ahash_report(struct sk_buff *skb, struct crypto_alg *alg)
         rhash.blocksize = alg->cra_blocksize;
         rhash.digestsize = __crypto_hash_alg_common(alg)->digestsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_HASH,
-                sizeof(struct crypto_report_hash), &rhash);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_HASH,
+                    sizeof(struct crypto_report_hash), &rhash))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: