diff options
| author | David S. Miller <davem@davemloft.net> | 2012-04-01 20:19:05 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 04:33:42 -0400 |
| commit | 6662df33f85b87bb29f2ecad124efe7bb2c08e05 (patch) | |
| tree | 13c8ac420b8d10ec3a7aa9aa7fdaa221e430c9cc /crypto/ablkcipher.c | |
| parent | b21dddb9dfe50ca1e205faf4b25900895494d25b (diff) | |
crypto: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/ablkcipher.c')
| -rw-r--r-- | crypto/ablkcipher.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c index a0f768c1d9aa..c22374bf9f1e 100644 --- a/crypto/ablkcipher.c +++ b/crypto/ablkcipher.c | |||
| @@ -397,9 +397,9 @@ static int crypto_ablkcipher_report(struct sk_buff *skb, struct crypto_alg *alg) | |||
| 397 | rblkcipher.max_keysize = alg->cra_ablkcipher.max_keysize; | 397 | rblkcipher.max_keysize = alg->cra_ablkcipher.max_keysize; |
| 398 | rblkcipher.ivsize = alg->cra_ablkcipher.ivsize; | 398 | rblkcipher.ivsize = alg->cra_ablkcipher.ivsize; |
| 399 | 399 | ||
| 400 | NLA_PUT(skb, CRYPTOCFGA_REPORT_BLKCIPHER, | 400 | if (nla_put(skb, CRYPTOCFGA_REPORT_BLKCIPHER, |
| 401 | sizeof(struct crypto_report_blkcipher), &rblkcipher); | 401 | sizeof(struct crypto_report_blkcipher), &rblkcipher)) |
| 402 | 402 | goto nla_put_failure; | |
| 403 | return 0; | 403 | return 0; |
| 404 | 404 | ||
| 405 | nla_put_failure: | 405 | nla_put_failure: |
| @@ -478,9 +478,9 @@ static int crypto_givcipher_report(struct sk_buff *skb, struct crypto_alg *alg) | |||
| 478 | rblkcipher.max_keysize = alg->cra_ablkcipher.max_keysize; | 478 | rblkcipher.max_keysize = alg->cra_ablkcipher.max_keysize; |
| 479 | rblkcipher.ivsize = alg->cra_ablkcipher.ivsize; | 479 | rblkcipher.ivsize = alg->cra_ablkcipher.ivsize; |
| 480 | 480 | ||
| 481 | NLA_PUT(skb, CRYPTOCFGA_REPORT_BLKCIPHER, | 481 | if (nla_put(skb, CRYPTOCFGA_REPORT_BLKCIPHER, |
| 482 | sizeof(struct crypto_report_blkcipher), &rblkcipher); | 482 | sizeof(struct crypto_report_blkcipher), &rblkcipher)) |
| 483 | 483 | goto nla_put_failure; | |
| 484 | return 0; | 484 | return 0; |
| 485 | 485 | ||
| 486 | nla_put_failure: | 486 | nla_put_failure: |