aboutsummaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2009-04-28 00:06:05 -0400
committerJens Axboe <jens.axboe@oracle.com>2009-04-28 02:14:50 -0400
commit4c94dece1baf320d925cedb231489c4e0358ac5a (patch)
treefd0738e2f82c806e921e6c872b704cfbef3c0a1d /block
parent9fd8d0e1bcb848257968d9a7d73ca4d890ea8bd1 (diff)
block: don't init rq fields unnecessarily
blk_get_request() always returns properly zeroed requests. Don't set fields to zero/NULL unnecessarily. [ Impact: cleanup ] Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r--block/scsi_ioctl.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index bb9aa43551b2..58cf4560f742 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -500,8 +500,6 @@ static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk,
500 500
501 rq = blk_get_request(q, WRITE, __GFP_WAIT); 501 rq = blk_get_request(q, WRITE, __GFP_WAIT);
502 rq->cmd_type = REQ_TYPE_BLOCK_PC; 502 rq->cmd_type = REQ_TYPE_BLOCK_PC;
503 rq->data_len = 0;
504 rq->extra_len = 0;
505 rq->timeout = BLK_DEFAULT_SG_TIMEOUT; 503 rq->timeout = BLK_DEFAULT_SG_TIMEOUT;
506 rq->cmd[0] = cmd; 504 rq->cmd[0] = cmd;
507 rq->cmd[4] = data; 505 rq->cmd[4] = data;