diff options
author | Jens Axboe <jens.axboe@oracle.com> | 2006-12-01 04:42:33 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2006-12-01 04:42:33 -0500 |
commit | bb37b94c68e7b37eecea8576039ae9396ca07839 (patch) | |
tree | 0b5dcbb3abb7710789d401126431f6f4dfe89e3a /block | |
parent | 0e75f9063f5c55fb0b0b546a7c356f8ec186825e (diff) |
[BLOCK] Cleanup unused variable passing
- ->init_queue() does not need the elevator passed in
- ->put_request() is a hot path and need not have the queue passed in
- cfq_update_io_seektime() does not need cfqd passed in
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/as-iosched.c | 2 | ||||
-rw-r--r-- | block/cfq-iosched.c | 9 | ||||
-rw-r--r-- | block/deadline-iosched.c | 2 | ||||
-rw-r--r-- | block/elevator.c | 4 | ||||
-rw-r--r-- | block/noop-iosched.c | 2 |
5 files changed, 9 insertions, 10 deletions
diff --git a/block/as-iosched.c b/block/as-iosched.c index 50b95e4c1425..00242111a457 100644 --- a/block/as-iosched.c +++ b/block/as-iosched.c | |||
@@ -1317,7 +1317,7 @@ static void as_exit_queue(elevator_t *e) | |||
1317 | /* | 1317 | /* |
1318 | * initialize elevator private data (as_data). | 1318 | * initialize elevator private data (as_data). |
1319 | */ | 1319 | */ |
1320 | static void *as_init_queue(request_queue_t *q, elevator_t *e) | 1320 | static void *as_init_queue(request_queue_t *q) |
1321 | { | 1321 | { |
1322 | struct as_data *ad; | 1322 | struct as_data *ad; |
1323 | 1323 | ||
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 1d9c3c70a9a0..e9019ed39b73 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -1464,8 +1464,7 @@ cfq_update_io_thinktime(struct cfq_data *cfqd, struct cfq_io_context *cic) | |||
1464 | } | 1464 | } |
1465 | 1465 | ||
1466 | static void | 1466 | static void |
1467 | cfq_update_io_seektime(struct cfq_data *cfqd, struct cfq_io_context *cic, | 1467 | cfq_update_io_seektime(struct cfq_io_context *cic, struct request *rq) |
1468 | struct request *rq) | ||
1469 | { | 1468 | { |
1470 | sector_t sdist; | 1469 | sector_t sdist; |
1471 | u64 total; | 1470 | u64 total; |
@@ -1617,7 +1616,7 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq, | |||
1617 | } | 1616 | } |
1618 | 1617 | ||
1619 | cfq_update_io_thinktime(cfqd, cic); | 1618 | cfq_update_io_thinktime(cfqd, cic); |
1620 | cfq_update_io_seektime(cfqd, cic, rq); | 1619 | cfq_update_io_seektime(cic, rq); |
1621 | cfq_update_idle_window(cfqd, cfqq, cic); | 1620 | cfq_update_idle_window(cfqd, cfqq, cic); |
1622 | 1621 | ||
1623 | cic->last_queue = jiffies; | 1622 | cic->last_queue = jiffies; |
@@ -1770,7 +1769,7 @@ static int cfq_may_queue(request_queue_t *q, int rw) | |||
1770 | /* | 1769 | /* |
1771 | * queue lock held here | 1770 | * queue lock held here |
1772 | */ | 1771 | */ |
1773 | static void cfq_put_request(request_queue_t *q, struct request *rq) | 1772 | static void cfq_put_request(struct request *rq) |
1774 | { | 1773 | { |
1775 | struct cfq_queue *cfqq = RQ_CFQQ(rq); | 1774 | struct cfq_queue *cfqq = RQ_CFQQ(rq); |
1776 | 1775 | ||
@@ -1951,7 +1950,7 @@ static void cfq_exit_queue(elevator_t *e) | |||
1951 | kfree(cfqd); | 1950 | kfree(cfqd); |
1952 | } | 1951 | } |
1953 | 1952 | ||
1954 | static void *cfq_init_queue(request_queue_t *q, elevator_t *e) | 1953 | static void *cfq_init_queue(request_queue_t *q) |
1955 | { | 1954 | { |
1956 | struct cfq_data *cfqd; | 1955 | struct cfq_data *cfqd; |
1957 | int i; | 1956 | int i; |
diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c index b7c5b34cb7b4..6d673e938d3e 100644 --- a/block/deadline-iosched.c +++ b/block/deadline-iosched.c | |||
@@ -356,7 +356,7 @@ static void deadline_exit_queue(elevator_t *e) | |||
356 | /* | 356 | /* |
357 | * initialize elevator private data (deadline_data). | 357 | * initialize elevator private data (deadline_data). |
358 | */ | 358 | */ |
359 | static void *deadline_init_queue(request_queue_t *q, elevator_t *e) | 359 | static void *deadline_init_queue(request_queue_t *q) |
360 | { | 360 | { |
361 | struct deadline_data *dd; | 361 | struct deadline_data *dd; |
362 | 362 | ||
diff --git a/block/elevator.c b/block/elevator.c index 8ccd163254b8..c0063f345c5d 100644 --- a/block/elevator.c +++ b/block/elevator.c | |||
@@ -129,7 +129,7 @@ static struct elevator_type *elevator_get(const char *name) | |||
129 | 129 | ||
130 | static void *elevator_init_queue(request_queue_t *q, struct elevator_queue *eq) | 130 | static void *elevator_init_queue(request_queue_t *q, struct elevator_queue *eq) |
131 | { | 131 | { |
132 | return eq->ops->elevator_init_fn(q, eq); | 132 | return eq->ops->elevator_init_fn(q); |
133 | } | 133 | } |
134 | 134 | ||
135 | static void elevator_attach(request_queue_t *q, struct elevator_queue *eq, | 135 | static void elevator_attach(request_queue_t *q, struct elevator_queue *eq, |
@@ -810,7 +810,7 @@ void elv_put_request(request_queue_t *q, struct request *rq) | |||
810 | elevator_t *e = q->elevator; | 810 | elevator_t *e = q->elevator; |
811 | 811 | ||
812 | if (e->ops->elevator_put_req_fn) | 812 | if (e->ops->elevator_put_req_fn) |
813 | e->ops->elevator_put_req_fn(q, rq); | 813 | e->ops->elevator_put_req_fn(rq); |
814 | } | 814 | } |
815 | 815 | ||
816 | int elv_may_queue(request_queue_t *q, int rw) | 816 | int elv_may_queue(request_queue_t *q, int rw) |
diff --git a/block/noop-iosched.c b/block/noop-iosched.c index 79af43179421..1c3de2b9a6b5 100644 --- a/block/noop-iosched.c +++ b/block/noop-iosched.c | |||
@@ -65,7 +65,7 @@ noop_latter_request(request_queue_t *q, struct request *rq) | |||
65 | return list_entry(rq->queuelist.next, struct request, queuelist); | 65 | return list_entry(rq->queuelist.next, struct request, queuelist); |
66 | } | 66 | } |
67 | 67 | ||
68 | static void *noop_init_queue(request_queue_t *q, elevator_t *e) | 68 | static void *noop_init_queue(request_queue_t *q) |
69 | { | 69 | { |
70 | struct noop_data *nd; | 70 | struct noop_data *nd; |
71 | 71 | ||