aboutsummaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-09-12 11:06:40 -0400
committerJens Axboe <axboe@kernel.dk>2012-09-12 16:25:12 -0400
commitd41570b7469724005eb78448a69289900f911963 (patch)
treec2d92ce5c5c370a4a50770ee84ea4fd50a57e010 /block
parente32463b2f7801d6561887c01db37b34958504635 (diff)
block/blk-tag.c: Remove useless kfree
Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged exists@ position r.p1,r.p2; expression e <= r.x,x,e1; iterator I; statement S; @@ if (x@p1 == NULL) { ... when != I(x,...) S when != e = e1 when != e += e1 when != e -= e1 when != ++e when != --e when != e++ when != e-- when != &e kfree@p2(x); ... return ...; } @ok depends on unchanged exists@ position any r.p1; position r.p2; expression x; @@ ... when != true x@p1 == NULL kfree@p2(x); @depends on !ok && unchanged@ position r.p2; expression x; @@ *kfree@p2(x); // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/blk-tag.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/block/blk-tag.c b/block/blk-tag.c
index 4af6f5cc1167..cc345e1d8d4e 100644
--- a/block/blk-tag.c
+++ b/block/blk-tag.c
@@ -186,7 +186,8 @@ int blk_queue_init_tags(struct request_queue *q, int depth,
186 tags = __blk_queue_init_tags(q, depth); 186 tags = __blk_queue_init_tags(q, depth);
187 187
188 if (!tags) 188 if (!tags)
189 goto fail; 189 return -ENOMEM;
190
190 } else if (q->queue_tags) { 191 } else if (q->queue_tags) {
191 rc = blk_queue_resize_tags(q, depth); 192 rc = blk_queue_resize_tags(q, depth);
192 if (rc) 193 if (rc)
@@ -203,9 +204,6 @@ int blk_queue_init_tags(struct request_queue *q, int depth,
203 queue_flag_set_unlocked(QUEUE_FLAG_QUEUED, q); 204 queue_flag_set_unlocked(QUEUE_FLAG_QUEUED, q);
204 INIT_LIST_HEAD(&q->tag_busy_list); 205 INIT_LIST_HEAD(&q->tag_busy_list);
205 return 0; 206 return 0;
206fail:
207 kfree(tags);
208 return -ENOMEM;
209} 207}
210EXPORT_SYMBOL(blk_queue_init_tags); 208EXPORT_SYMBOL(blk_queue_init_tags);
211 209